π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
[WIKI-421] fix: Toolbar not reflecting strikethrough state (#7255)
Vipin Chaudharyfbcc8fc8a09f
diff --git a/packages/editor/src/core/components/menus/bubble-menu/root.tsx b/packages/editor/src/core/components/menus/bubble-menu/root.tsxindex 30a7c5620b..a3fa3e2d7d 100644--- a/packages/editor/src/core/components/menus/bubble-menu/root.tsx+++ b/packages/editor/src/core/components/menus/bubble-menu/root.tsx@@ -10,6 +10,7 @@ import {BubbleMenuLinkSelector,BubbleMenuNodeSelector,CodeItem,+ EditorMenuItem,ItalicItem,StrikeThroughItem,TextAlignItem,@@ -23,6 +24,7 @@ import { CORE_EXTENSIONS } from "@/constants/extension";import { isCellSelection } from "@/extensions/table/table/utilities/is-cell-selection";// local componentsimport { TextAlignmentSelector } from "./alignment-selector";+import { TEditorCommands } from "@/types";type EditorBubbleMenuProps = Omit<BubbleMenuProps, "children">;@@ -31,19 +33,19 @@ export interface EditorStateType {bold: boolean;italic: boolean;underline: boolean;- strike: boolean;+ strikethrough: boolean;left: boolean;right: boolean;center: boolean;color: { key: string; label: string; textColor: string; backgroundColor: string } | undefined;backgroundColor:- | {- key: string;- label: string;- textColor: string;- backgroundColor: string;- }- | undefined;+ | {+ key: string;+ label: string;+ textColor: string;+ backgroundColor: string;+ }+ | undefined;}export const EditorBubbleMenu: FC<EditorBubbleMenuProps> = (props: { editor: Editor }) => {@@ -58,8 +60,10 @@ export const EditorBubbleMenu: FC<EditorBubbleMenuProps> = (props: { editor: Edibold: BoldItem(props.editor),italic: ItalicItem(props.editor),underline: UnderLineItem(props.editor),- strike: StrikeThroughItem(props.editor),- textAlign: TextAlignItem(props.editor),+ strikethrough: StrikeThroughItem(props.editor),+ "text-align": TextAlignItem(props.editor),+ } satisfies {+ [K in TEditorCommands]?: EditorMenuItem<K>;};const editorState: EditorStateType = useEditorState({@@ -69,10 +73,10 @@ export const EditorBubbleMenu: FC<EditorBubbleMenuProps> = (props: { editor: Edibold: formattingItems.bold.isActive(),italic: formattingItems.italic.isActive(),underline: formattingItems.underline.isActive(),- strike: formattingItems.strike.isActive(),- left: formattingItems.textAlign.isActive({ alignment: "left" }),- right: formattingItems.textAlign.isActive({ alignment: "right" }),- center: formattingItems.textAlign.isActive({ alignment: "center" }),+ strikethrough: formattingItems.strikethrough.isActive(),+ left: formattingItems["text-align"].isActive({ alignment: "left" }),+ right: formattingItems["text-align"].isActive({ alignment: "right" }),+ center: formattingItems["text-align"].isActive({ alignment: "center" }),color: COLORS_LIST.find((c) => TextColorItem(editor).isActive({ color: c.key })),backgroundColor: COLORS_LIST.find((c) => BackgroundColorItem(editor).isActive({ color: c.key })),}),@@ -80,7 +84,7 @@ export const EditorBubbleMenu: FC<EditorBubbleMenuProps> = (props: { editor: Ediconst basicFormattingOptions = editorState.code? [formattingItems.code]- : [formattingItems.bold, formattingItems.italic, formattingItems.underline, formattingItems.strike];+ : [formattingItems.bold, formattingItems.italic, formattingItems.underline, formattingItems.strikethrough];const bubbleMenuProps: EditorBubbleMenuProps = {...props,