π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
fix: escape markdown content for images (#6096)
Aaryan Khandelwalfc5293602436
diff --git a/packages/editor/src/core/extensions/custom-image/custom-image.ts b/packages/editor/src/core/extensions/custom-image/custom-image.tsindex a232bb258a..3b64db8d09 100644--- a/packages/editor/src/core/extensions/custom-image/custom-image.ts+++ b/packages/editor/src/core/extensions/custom-image/custom-image.ts@@ -1,11 +1,9 @@import { Editor, mergeAttributes } from "@tiptap/core";import { Image } from "@tiptap/extension-image";-import { MarkdownSerializerState } from "@tiptap/pm/markdown";-import { Node } from "@tiptap/pm/model";import { ReactNodeViewRenderer } from "@tiptap/react";import { v4 as uuidv4 } from "uuid";// extensions-import { CustomImageNode, ImageAttributes } from "@/extensions/custom-image";+import { CustomImageNode } from "@/extensions/custom-image";// pluginsimport { TrackImageDeletionPlugin, TrackImageRestorationPlugin, isFileValid } from "@/plugins/image";// types@@ -126,14 +124,9 @@ export const CustomImageExtension = (props: TFileHandler) => {deletedImageSet: new Map<string, boolean>(),uploadInProgress: false,maxFileSize,+ // escape markdown for imagesmarkdown: {- serialize(state: MarkdownSerializerState, node: Node) {- const attrs = node.attrs as ImageAttributes;- const imageSource = state.esc(this?.editor?.commands?.getImageSource?.(attrs.src) || attrs.src);- const imageWidth = state.esc(attrs.width?.toString());- state.write(`<img src="${state.esc(imageSource)}" width="${imageWidth}" />`);- state.closeBlock(node);- },+ serialize() {},},};},diff --git a/packages/editor/src/core/extensions/custom-image/read-only-custom-image.ts b/packages/editor/src/core/extensions/custom-image/read-only-custom-image.tsindex 3248329f03..c27970d928 100644--- a/packages/editor/src/core/extensions/custom-image/read-only-custom-image.ts+++ b/packages/editor/src/core/extensions/custom-image/read-only-custom-image.ts@@ -1,10 +1,8 @@import { mergeAttributes } from "@tiptap/core";import { Image } from "@tiptap/extension-image";-import { MarkdownSerializerState } from "@tiptap/pm/markdown";-import { Node } from "@tiptap/pm/model";import { ReactNodeViewRenderer } from "@tiptap/react";// components-import { CustomImageNode, ImageAttributes, UploadImageExtensionStorage } from "@/extensions/custom-image";+import { CustomImageNode, UploadImageExtensionStorage } from "@/extensions/custom-image";// typesimport { TFileHandler } from "@/types";@@ -54,14 +52,9 @@ export const CustomReadOnlyImageExtension = (props: Pick<TFileHandler, "getAssetaddStorage() {return {fileMap: new Map(),+ // escape markdown for imagesmarkdown: {- serialize(state: MarkdownSerializerState, node: Node) {- const attrs = node.attrs as ImageAttributes;- const imageSource = state.esc(this?.editor?.commands?.getImageSource?.(attrs.src) || attrs.src);- const imageWidth = state.esc(attrs.width?.toString());- state.write(`<img src="${state.esc(imageSource)}" width="${imageWidth}" />`);- state.closeBlock(node);- },+ serialize() {},},};},