π₯π₯π₯ Open-source Jira, Linear, Monday, and ClickUp alternative. Plane is a modern project management platform to manage tasks, sprints, docs, and triage.
TypeScript boardsbug-trackerdjangodockerganttissue-trackerjirajira-alternativekanbanlinearpostgresqlproduct-managementproject-managementproject-planningpythonreactredistypesciptvitework-management
fix: work item attachment count mutation (#6670)
Anmol Singh Bhatiafde8630c5ba6
diff --git a/web/core/components/issues/issue-detail-widgets/issue-detail-widget-collapsibles.tsx b/web/core/components/issues/issue-detail-widgets/issue-detail-widget-collapsibles.tsxindex 9162e63161..26ec7b6bfa 100644--- a/web/core/components/issues/issue-detail-widgets/issue-detail-widget-collapsibles.tsx+++ b/web/core/components/issues/issue-detail-widgets/issue-detail-widget-collapsibles.tsx@@ -26,7 +26,7 @@ export const IssueDetailWidgetCollapsibles: FC<Props> = observer((props) => {const {issue: { getIssueById },subIssues: { subIssuesByIssueId },- attachment: { getAttachmentsUploadStatusByIssueId },+ attachment: { getAttachmentsCountByIssueId, getAttachmentsUploadStatusByIssueId },relation: { getRelationCountByIssueId },} = useIssueDetail();@@ -41,8 +41,8 @@ export const IssueDetailWidgetCollapsibles: FC<Props> = observer((props) => {const shouldRenderRelations = issueRelationsCount > 0;const shouldRenderLinks = !!issue?.link_count && issue?.link_count > 0;const attachmentUploads = getAttachmentsUploadStatusByIssueId(issueId);- const shouldRenderAttachments =- (!!issue?.attachment_count && issue?.attachment_count > 0) || (!!attachmentUploads && attachmentUploads.length > 0);+ const attachmentsCount = getAttachmentsCountByIssueId(issueId);+ const shouldRenderAttachments = attachmentsCount > 0 || (!!attachmentUploads && attachmentUploads.length > 0);return (<div className="flex flex-col">diff --git a/web/core/store/issue/issue-details/attachment.store.ts b/web/core/store/issue/issue-details/attachment.store.tsindex 73474a3e83..90c28840a2 100644--- a/web/core/store/issue/issue-details/attachment.store.ts+++ b/web/core/store/issue/issue-details/attachment.store.ts@@ -51,6 +51,7 @@ export interface IIssueAttachmentStore extends IIssueAttachmentStoreActions {getAttachmentsUploadStatusByIssueId: (issueId: string) => TAttachmentUploadStatus[] | undefined;getAttachmentsByIssueId: (issueId: string) => string[] | undefined;getAttachmentById: (attachmentId: string) => TIssueAttachment | undefined;+ getAttachmentsCountByIssueId: (issueId: string) => number;}export class IssueAttachmentStore implements IIssueAttachmentStore {@@ -109,6 +110,11 @@ export class IssueAttachmentStore implements IIssueAttachmentStore {return this.attachmentMap[attachmentId] ?? undefined;};+ getAttachmentsCountByIssueId = (issueId: string) => {+ const attachments = this.getAttachmentsByIssueId(issueId);+ return attachments?.length ?? 0;+ };+// actionsaddAttachments = (issueId: string, attachments: TIssueAttachment[]) => {if (attachments && attachments.length > 0) {@@ -155,12 +161,14 @@ export class IssueAttachmentStore implements IIssueAttachmentStore {this.debouncedUpdateProgress(issueId, tempId, progressPercentage);});- const issueAttachmentsCount = this.getAttachmentsByIssueId(issueId)?.length ?? 0;if (response && response.id) {runInAction(() => {update(this.attachments, [issueId], (attachmentIds = []) => uniq(concat(attachmentIds, [response.id])));set(this.attachmentMap, response.id, response);+ this.rootIssueStore.issues.updateIssue(issueId, {+ attachment_count: this.getAttachmentsCountByIssueId(issueId),+ });});}@@ -182,7 +190,6 @@ export class IssueAttachmentStore implements IIssueAttachmentStore {issueId,attachmentId);- const issueAttachmentsCount = this.getAttachmentsByIssueId(issueId)?.length ?? 1;runInAction(() => {update(this.attachments, [issueId], (attachmentIds = []) => {@@ -191,7 +198,7 @@ export class IssueAttachmentStore implements IIssueAttachmentStore {});delete this.attachmentMap[attachmentId];this.rootIssueStore.issues.updateIssue(issueId, {- attachment_count: issueAttachmentsCount - 1, // decrement attachment count+ attachment_count: this.getAttachmentsCountByIssueId(issueId),});});