Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: revert show tests -they are bad (#39421)

Pavel Feldman001480539b80
diff --git a/packages/devtools/src/devtools.tsx b/packages/devtools/src/devtools.tsx
index 5fd3a51934..20f97e5f04 100644
--- a/packages/devtools/src/devtools.tsx
+++ b/packages/devtools/src/devtools.tsx
@@ -240,7 +240,6 @@ export const DevTools: React.FC<{ wsUrl?: string }> = ({ wsUrl }) => {
role='tab'
aria-selected={tab.selected}
title={tab.url || ''}
- aria-disabled={!channel}
onClick={() => channel?.selectTab({ pageId: tab.pageId })}
>
<span className='tab-favicon' aria-hidden='true'>{tabFavicon(tab.url)}</span>
@@ -248,7 +247,6 @@ export const DevTools: React.FC<{ wsUrl?: string }> = ({ wsUrl }) => {
<button
className='tab-close'
title='Close tab'
- disabled={!channel}
onClick={e => {
e.stopPropagation();
channel?.closeTab({ pageId: tab.pageId });
@@ -259,7 +257,7 @@ export const DevTools: React.FC<{ wsUrl?: string }> = ({ wsUrl }) => {
</div>
))}
</div>
- <button id='new-tab-btn' className='new-tab-btn' title='New Tab' disabled={!channel} onClick={() => channel?.newTab()}>
+ <button id='new-tab-btn' className='new-tab-btn' title='New Tab' onClick={() => channel?.newTab()}>
<PlusIcon />
</button>
<div className='interactive-controls'>
@@ -294,13 +292,13 @@ export const DevTools: React.FC<{ wsUrl?: string }> = ({ wsUrl }) => {
{/* Toolbar */}
<div ref={toolbarRef} className='toolbar'>
- <button className='nav-btn' title='Back' disabled={!channel} onClick={() => channel?.back()}>
+ <button className='nav-btn' title='Back' onClick={() => channel?.back()}>
<ChevronLeftIcon />
</button>
- <button className='nav-btn' title='Forward' disabled={!channel} onClick={() => channel?.forward()}>
+ <button className='nav-btn' title='Forward' onClick={() => channel?.forward()}>
<ChevronRightIcon />
</button>
- <button className='nav-btn' title='Reload' disabled={!channel} onClick={() => channel?.reload()}>
+ <button className='nav-btn' title='Reload' onClick={() => channel?.reload()}>
<ReloadIcon />
</button>
<input
@@ -311,7 +309,6 @@ export const DevTools: React.FC<{ wsUrl?: string }> = ({ wsUrl }) => {
spellCheck={false}
autoComplete='off'
value={url}
- disabled={!channel}
onChange={e => setUrl(e.target.value)}
onKeyDown={onOmniboxKeyDown}
onFocus={e => e.target.select()}
diff --git a/packages/devtools/src/grid.tsx b/packages/devtools/src/grid.tsx
index 00b90a257e..fb73cf8a80 100644
--- a/packages/devtools/src/grid.tsx
+++ b/packages/devtools/src/grid.tsx
@@ -130,10 +130,10 @@ const SessionChip: React.FC<{ sessionFile: SessionFile; canConnect: boolean; vis
}, [channel]);
const chipTitle = selectedTab ? `[${config.name}] ${selectedTab.url} \u2014 ${selectedTab.title}` : config.name;
- const clickable = canConnect && !!wsUrl;
+ const clickable = canConnect && wsUrl !== null;
return (
- <a className={'session-chip' + (canConnect ? '' : ' disconnected') + (wsUrl === null ? ' not-supported' : '')} href={clickable ? href : undefined} aria-disabled={!clickable} title={chipTitle} onClick={e => {
+ <a className={'session-chip' + (canConnect ? '' : ' disconnected') + (wsUrl === null ? ' not-supported' : '')} href={clickable ? href : undefined} title={chipTitle} onClick={e => {
e.preventDefault();
if (clickable)
navigate(href);
diff --git a/packages/devtools/src/index.tsx b/packages/devtools/src/index.tsx
index 2459ec7ac4..664fbbf935 100644
--- a/packages/devtools/src/index.tsx
+++ b/packages/devtools/src/index.tsx
@@ -53,7 +53,7 @@ const App: React.FC = () => {
};
}, [model]);
- React.useLayoutEffect(() => {
+ React.useEffect(() => {
const onPopState = () => setSocketPath(parseHash());
window.addEventListener('popstate', onPopState);
return () => window.removeEventListener('popstate', onPopState);
diff --git a/packages/playwright/src/cli/client/devtoolsApp.ts b/packages/playwright/src/cli/client/devtoolsApp.ts
index 7e7e34f0f2..f5d121e9d8 100644
--- a/packages/playwright/src/cli/client/devtoolsApp.ts
+++ b/packages/playwright/src/cli/client/devtoolsApp.ts
@@ -17,11 +17,10 @@
import fs from 'fs';
import path from 'path';
import os from 'os';
-import crypto from 'crypto';
import net from 'net';
import { chromium } from 'playwright-core';
-import { gracefullyProcessExitDoNotHang, HttpServer, isUnderTest } from 'playwright-core/lib/utils';
+import { gracefullyProcessExitDoNotHang, HttpServer } from 'playwright-core/lib/utils';
import { findChromiumChannelBestEffort, registryDirectory } from 'playwright-core/lib/server/registry/index';
import { createClientInfo, Registry } from './registry';
@@ -117,7 +116,7 @@ async function handleApiRequest(clientInfo: ClientInfo, request: http.IncomingMe
response.end(JSON.stringify({ error: 'Not found' }));
}
-async function openDevToolsApp(): Promise<{ page?: Page, url: string }> {
+async function openDevToolsApp(): Promise<Page> {
const httpServer = new HttpServer();
const libDir = require.resolve('playwright-core/package.json');
const devtoolsDir = path.join(path.dirname(libDir), 'lib/vite/devtools');
@@ -141,12 +140,10 @@ async function openDevToolsApp(): Promise<{ page?: Page, url: string }> {
});
await httpServer.start();
const url = httpServer.urlPrefix('human-readable');
- if (isUnderTest())
- return { url };
const { page } = await launchApp('devtools');
await page.goto(url);
- return { page, url };
+ return page;
}
async function launchApp(appName: string) {
@@ -215,15 +212,13 @@ function socketsDirectory() {
}
function devtoolsSocketPath() {
- const suffix = process.env.PLAYWRIGHT_DAEMON_SESSION_DIR ? crypto.createHash('sha256').update(process.env.PLAYWRIGHT_DAEMON_SESSION_DIR).digest('hex').substring(0, 8) : '';
return process.platform === 'win32'
- ? `\\\\.\\pipe\\playwright-devtools-${process.env.USERNAME || 'default'}${suffix}`
- : path.join(socketsDirectory(), `devtools${suffix}.sock`);
+ ? `\\\\.\\pipe\\playwright-devtools-${process.env.USERNAME || 'default'}`
+ : path.join(socketsDirectory(), 'devtools.sock');
}
-async function acquireSingleton(): Promise<net.Server | string> {
+async function acquireSingleton(): Promise<net.Server> {
const socketPath = devtoolsSocketPath();
- await fs.promises.mkdir(path.dirname(socketPath), { recursive: true });
return await new Promise((resolve, reject) => {
const server = net.createServer();
@@ -233,11 +228,8 @@ async function acquireSingleton(): Promise<net.Server | string> {
return reject(err);
const client = net.connect(socketPath, () => {
client.write('bringToFront');
- });
- let data = '';
- client.on('data', chunk => { data += chunk.toString(); });
- client.on('end', () => {
- resolve(data);
+ client.end();
+ reject(new Error('already running'));
});
client.on('error', () => {
if (process.platform !== 'win32')
@@ -249,36 +241,20 @@ async function acquireSingleton(): Promise<net.Server | string> {
}
async function main() {
- const result = await acquireSingleton();
- let status = typeof result === 'string' ? result : 'Starting';
-
- if (typeof result !== 'string') {
- const server = result;
- process.on('exit', () => server.close());
-
- let page: Page | undefined = undefined;
- server.on('connection', socket => {
- socket.on('data', data => {
- if (data.toString() === 'bringToFront')
- page?.bringToFront().catch(() => {});
- socket.end(status);
- });
- });
-
- const app = await openDevToolsApp();
- page = app.page;
- status = `DevTools pid ${process.pid} listening on ${app.url}`;
+ let server: net.Server | undefined;
+ process.on('exit', () => server?.close());
+ try {
+ server = await acquireSingleton();
+ } catch {
+ return;
}
-
-
- // eslint-disable-next-line no-console
- console.log(status);
- // eslint-disable-next-line no-console
- console.log('<EOF>');
+ const page = await openDevToolsApp();
+ server.on('connection', socket => {
+ socket.on('data', data => {
+ if (data.toString() === 'bringToFront')
+ page?.bringToFront().catch(() => {});
+ });
+ });
}
-void main().catch(e => {
- // eslint-disable-next-line no-console
- console.log(e);
- throw e;
-});
+void main();
diff --git a/packages/playwright/src/cli/client/program.ts b/packages/playwright/src/cli/client/program.ts
index c181c26ed4..5bde14a155 100644
--- a/packages/playwright/src/cli/client/program.ts
+++ b/packages/playwright/src/cli/client/program.ts
@@ -193,29 +193,9 @@ export async function program(options?: { embedderVersion?: string}) {
const daemonScript = path.join(__dirname, 'devtoolsApp.js');
const child = spawn(process.execPath, [daemonScript], {
detached: true,
- stdio: ['ignore', 'pipe', 'ignore'],
+ stdio: 'ignore',
});
-
- const status = await new Promise<string>((resolve, reject) => {
- let outLog = '';
- child.stdout!.on('data', (data: Buffer) => {
- outLog += data.toString();
- if (outLog.includes('<EOF>'))
- resolve(outLog.split('<EOF>')[0]);
- });
- child.on('close', code => {
- process.exitCode = code || 1;
- reject(new Error(outLog));
- });
- });
-
- child.stdout!.destroy();
child.unref();
-
- // TODO: update check-deps to allow importing isUnderTest()
- if (process.env.PWTEST_UNDER_TEST)
- console.log(status);
-
return;
}
default: {
@@ -367,7 +347,7 @@ async function killAllDaemons(): Promise<void> {
const result = execSync(
`powershell -NoProfile -NonInteractive -Command `
+ `"Get-CimInstance Win32_Process `
- + `| Where-Object { ($_.CommandLine -like '*-server*' -and $_.CommandLine -like '*--daemon-session*') -or $_.CommandLine -like '*devtoolsApp.js*' } `
+ + `| Where-Object { $_.CommandLine -like '*-server*' -and $_.CommandLine -like '*--daemon-session*' } `
+ `| ForEach-Object { Stop-Process -Id $_.ProcessId -Force -ErrorAction SilentlyContinue; $_.ProcessId }"`,
{ encoding: 'utf-8' }
);
@@ -381,7 +361,7 @@ async function killAllDaemons(): Promise<void> {
const result = execSync('ps aux', { encoding: 'utf-8' });
const lines = result.split('\n');
for (const line of lines) {
- if ((line.includes('-server') && line.includes('--daemon-session')) || line.includes('devtoolsApp.js')) {
+ if ((line.includes('-server')) && line.includes('--daemon-session')) {
const parts = line.trim().split(/\s+/);
const pid = parts[1];
if (pid && /^\d+$/.test(pid)) {
diff --git a/tests/mcp/cli-fixtures.ts b/tests/mcp/cli-fixtures.ts
index a8c65cc6e9..a40b1a8d98 100644
--- a/tests/mcp/cli-fixtures.ts
+++ b/tests/mcp/cli-fixtures.ts
@@ -33,23 +33,21 @@ export const test = baseTest.extend<{
}>;
}>({
cli: async ({ mcpBrowser, mcpHeadless, childProcess }, use) => {
- const daemons: { session?: string, pid: number }[] = [];
+ const sessions: { name: string, pid: number }[] = [];
await fs.promises.mkdir(test.info().outputPath('.playwright'), { recursive: true });
await use(async (...args: string[]) => {
const cliArgs = args.filter(arg => typeof arg === 'string');
const cliOptions = args.findLast(arg => typeof arg === 'object') || {};
- return await runCli(childProcess, cliArgs, cliOptions, { mcpBrowser, mcpHeadless }, daemons);
+ return await runCli(childProcess, cliArgs, cliOptions, { mcpBrowser, mcpHeadless }, sessions);
});
- for (const daemon of daemons) {
- if (daemon.session) {
- await runCli(childProcess, ['--session=' + daemon.session, 'close'], {}, { mcpBrowser, mcpHeadless }, []).catch(e => {
- if (!e.message.includes('is not running'))
- throw e;
- });
- }
- killProcessGroup(daemon.pid);
+ for (const session of sessions) {
+ await runCli(childProcess, ['--session=' + session.name, 'close'], {}, { mcpBrowser, mcpHeadless }, []).catch(e => {
+ if (!e.message.includes('is not running'))
+ throw e;
+ });
+ killProcessGroup(session.pid);
}
const daemonDir = path.join(test.info().outputDir, 'daemon');
@@ -59,7 +57,7 @@ export const test = baseTest.extend<{
},
});
-async function runCli(childProcess: CommonFixtures['childProcess'], args: string[], cliOptions: { cwd?: string, env?: Record<string, string> }, options: { mcpBrowser: string, mcpHeadless: boolean }, daemons: { session?: string, pid: number }[]) {
+async function runCli(childProcess: CommonFixtures['childProcess'], args: string[], cliOptions: { cwd?: string, env?: Record<string, string> }, options: { mcpBrowser: string, mcpHeadless: boolean }, sessions: { name: string, pid: number }[]) {
const stepTitle = `cli ${args.join(' ')}`;
return await test.step(stepTitle, async () => {
const testInfo = test.info();
@@ -88,12 +86,7 @@ async function runCli(childProcess: CommonFixtures['childProcess'], args: string
const matches = cli.stdout.includes('### Browser') ? cli.stdout.match(/Browser `(.+)` opened with pid (\d+)\./) : undefined;
const [, sessionName, pid] = matches ?? [];
if (sessionName && pid)
- daemons.push({ session: sessionName, pid: +pid });
-
- const devtoolsMatch = cli.stdout.match(/DevTools pid (\d+) listening/);
- if (devtoolsMatch)
- daemons.push({ pid: +devtoolsMatch[1] });
-
+ sessions.push({ name: sessionName, pid: +pid });
return {
exitCode: await cli.exitCode,
output: cli.stdout.trim(),
diff --git a/tests/mcp/cli-show.spec.ts b/tests/mcp/cli-show.spec.ts
deleted file mode 100644
index 7450cddf2c..0000000000
--- a/tests/mcp/cli-show.spec.ts
+++ /dev/null
@@ -1,267 +0,0 @@
-/**
- * Copyright (c) Microsoft Corporation.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import { test as cliTest, expect } from './cli-fixtures';
-
-const test = cliTest.extend<{ showServer: string }>({
- showServer: async ({ cli }, use) => {
- const { output } = await cli('show', { env: { PWTEST_UNDER_TEST: '1' } });
- const urlMatch = output.match(/listening on (http:\/\/localhost:\d+)/);
- expect(urlMatch).toBeTruthy();
- await use(urlMatch![1]);
- },
- baseURL: ({ showServer }, use) => use(showServer),
-});
-
-test('grid', async ({ cli, page, server }) => {
- await cli('open', server.PREFIX);
- await page.goto('/');
- await expect(page.getByRole('link', { name: 'default' })).toMatchAriaSnapshot(`
- - link /default/:
- - button "Close session"
- - img "screencast"
- `);
-});
-
-test('show interaction toggle', async ({ cli, page, server }) => {
- await cli('open', server.EMPTY_PAGE);
- await page.goto('/');
- await page.getByRole('link', { name: /default/ }).click();
- await expect(page.getByRole('button', { name: 'Read-only' })).toHaveAttribute('aria-pressed', 'true');
- await expect(page.getByRole('button', { name: 'Interactive' })).toHaveAttribute('aria-pressed', 'false');
-
- await page.getByRole('button', { name: 'Interactive' }).click();
- await expect(page.getByRole('button', { name: 'Read-only' })).toHaveAttribute('aria-pressed', 'false');
- await expect(page.getByRole('button', { name: 'Interactive' })).toHaveAttribute('aria-pressed', 'true');
-});
-
-test('clicking screen auto-engages interactive mode', async ({ cli, page, server }) => {
- await cli('open', server.PREFIX + '/css-transition.html');
- await page.goto('/');
- await page.getByRole('link', { name: /default/ }).click();
-
- // Starts in Read-only mode.
- await expect(page.getByRole('button', { name: 'Read-only' })).toHaveAttribute('aria-pressed', 'true');
- await expect(page.getByRole('button', { name: 'Interactive' })).toHaveAttribute('aria-pressed', 'false');
-
- // Clicking the screen engages interactive mode.
- await page.locator('.screen').click();
- await expect(page.getByRole('button', { name: 'Interactive' })).toHaveAttribute('aria-pressed', 'true');
- await expect(page.getByRole('button', { name: 'Read-only' })).toHaveAttribute('aria-pressed', 'false');
-});
-
-test('update omnibox on navigation', async ({ cli, page, server }) => {
- await cli('open', server.PREFIX + '/title.html');
- await page.goto('/');
- await page.getByRole('link', { name: /default/ }).click();
- await expect(page.getByRole('textbox', { name: 'Search or enter URL' })).toMatchAriaSnapshot(`
- - textbox "Search or enter URL": /.*\/title\.html/
- `);
-});
-
-test('omnibox navigates on Enter', async ({ cli, page, server }) => {
- server.setContent('/omnibox-target.html', `<title>Omnibox Target</title><h1>target</h1>`, 'text/html');
-
- await cli('open', server.EMPTY_PAGE);
- await page.goto('/');
- await page.getByRole('link', { name: /default/ }).click();
-
- await expect(page.getByRole('textbox', { name: 'Search or enter URL' })).toHaveValue(server.EMPTY_PAGE);
- await page.getByRole('textbox', { name: 'Search or enter URL' }).fill(server.PREFIX + '/omnibox-target.html');
- await page.getByRole('textbox', { name: 'Search or enter URL' }).press('Enter');
-
- await expect(page.getByRole('tab', { name: 'Omnibox Target' })).toBeVisible();
- await expect(page.getByRole('textbox', { name: 'Search or enter URL' })).toHaveValue(server.PREFIX + '/omnibox-target.html');
-});
-
-test('toolbar back/forward/reload', async ({ cli, page, server }) => {
- server.setContent('/history-first.html', `<title>History First</title><h1>first</h1>`, 'text/html');
- server.setContent('/history-second.html', `<title>History Second</title><h1>second</h1>`, 'text/html');
- server.setContent('/reload-counter.html', `
- <title>Reload Counter</title>
- <script>
- const next = (Number(sessionStorage.getItem('reload-count') || '0') + 1);
- sessionStorage.setItem('reload-count', String(next));
- document.title = 'Reload Counter ' + next;
- </script>
- `, 'text/html');
-
- await cli('open', server.PREFIX + '/history-first.html');
- await page.goto('/');
- await page.getByRole('link', { name: /default/ }).click();
-
- const omnibox = page.getByRole('textbox', { name: 'Search or enter URL' });
- await expect(omnibox).toHaveValue(server.PREFIX + '/history-first.html');
- await omnibox.fill(server.PREFIX + '/history-second.html');
- await omnibox.press('Enter');
- await expect(page.getByRole('tab', { name: 'History Second' })).toBeVisible();
-
- await page.getByRole('button', { name: 'Back' }).click();
- await expect(page.getByRole('tab', { name: 'History First' })).toBeVisible();
-
- await page.getByRole('button', { name: 'Forward' }).click();
- await expect(page.getByRole('tab', { name: 'History Second' })).toBeVisible();
-
- await expect(omnibox).toHaveValue(server.PREFIX + '/history-second.html');
- await omnibox.fill(server.PREFIX + '/reload-counter.html');
- await omnibox.press('Enter');
- await expect(page.getByRole('tab', { name: 'Reload Counter 1' })).toBeVisible();
-
- await page.getByRole('button', { name: 'Reload' }).click();
- await expect(page.getByRole('tab', { name: 'Reload Counter 2' })).toBeVisible();
-});
-
-test('chrome devtools', async ({ cli, page, server, mcpBrowser }) => {
- test.skip(mcpBrowser !== 'chromium' && mcpBrowser !== 'chrome');
- await cli('open', server.PREFIX);
- await page.goto('/');
- await page.getByRole('link', { name: /default/ }).click();
-
- await page.getByRole('button', { name: 'Interactive' }).click();
- await page.getByRole('button', { name: 'Chrome DevTools' }).click();
- const devtools = page.frameLocator('iframe[title="Chrome DevTools"]');
- await devtools.getByRole('tab', { name: 'Console' }).click();
-
- await cli('eval', 'console.log("hello-from-cli-show")');
- await expect(devtools.getByText('hello-from-cli-show')).toBeVisible();
-});
-
-test('read-only closes chrome devtools', async ({ cli, page, server, mcpBrowser }) => {
- test.skip(mcpBrowser !== 'chromium' && mcpBrowser !== 'chrome');
- await cli('open', server.PREFIX);
- await page.goto('/');
- await page.getByRole('link', { name: /default/ }).click();
-
- await page.getByRole('button', { name: 'Interactive' }).click();
- await page.getByRole('button', { name: 'Chrome DevTools' }).click();
- await expect(page.getByRole('button', { name: 'Chrome DevTools' })).toHaveAttribute('aria-pressed', 'true');
- await expect(page.locator('iframe[title="Chrome DevTools"]')).toHaveCount(1);
-
- await page.getByRole('button', { name: 'Read-only' }).click();
- await expect(page.getByRole('button', { name: 'Chrome DevTools' })).toHaveAttribute('aria-pressed', 'false');
- await expect(page.locator('iframe[title="Chrome DevTools"]')).toHaveCount(0);
-});
-
-test('pick locator disable paths', async ({ cli, page, server }) => {
- await cli('open', server.PREFIX + '/css-transition.html');
- await page.goto('/');
- await page.getByRole('link', { name: /default/ }).click();
-
- await expect(page.getByRole('button', { name: 'Pick locator' })).toHaveAttribute('aria-pressed', 'false');
-
- // Disable via toolbar toggle.
- await page.getByRole('button', { name: 'Pick locator' }).click();
- await expect(page.getByRole('button', { name: 'Pick locator' })).toHaveAttribute('aria-pressed', 'true');
- await expect(page.getByText('Click an element to pick its locator')).toBeVisible();
-
- await page.getByRole('button', { name: 'Pick locator' }).click();
- await expect(page.getByRole('button', { name: 'Pick locator' })).toHaveAttribute('aria-pressed', 'false');
- await expect(page.getByText('Click an element to pick its locator')).toBeHidden();
-
- // Disable via Escape while focused on the screen.
- await page.getByRole('button', { name: 'Pick locator' }).click();
- await expect(page.getByRole('button', { name: 'Pick locator' })).toHaveAttribute('aria-pressed', 'true');
- await expect(page.getByText('Click an element to pick its locator')).toBeVisible();
-
- await page.locator('.screen').click();
- await page.keyboard.press('Escape');
-
- await expect(page.getByRole('button', { name: 'Pick locator' })).toHaveAttribute('aria-pressed', 'false');
- await expect(page.getByText('Click an element to pick its locator')).toBeHidden();
-});
-
-test('pick locator copies locator to clipboard', async ({ cli, page, server, browserName }) => {
- server.setContent('/pick-locator-target.html', `<style>@keyframes a{0%{opacity:1}100%{opacity:.9}}</style><div id='picker-target' style='position:fixed; inset:0; background:red; animation:a 1s infinite'></div>`, 'text/html');
-
- await cli('open', server.PREFIX + '/pick-locator-target.html');
- await page.goto('/');
- if (browserName === 'chromium')
- await page.context().grantPermissions(['clipboard-read', 'clipboard-write']);
- await page.getByRole('link', { name: /default/ }).click();
-
- await page.getByRole('button', { name: 'Interactive' }).click();
- await page.getByRole('button', { name: 'Pick locator' }).click();
- await expect(page.getByRole('button', { name: 'Pick locator' })).toHaveAttribute('aria-pressed', 'true');
- await page.locator('.screen').click();
- await expect(page.getByText(/^Copied:/)).toBeVisible();
- if (browserName === 'chromium') {
- const copied = await page.evaluate(() => navigator.clipboard.readText());
- expect(copied).toContain('#picker-target');
- }
-});
-
-test('locator picking is disabled when switching back to Read-only', async ({ cli, page, server }) => {
- await cli('open', server.PREFIX + '/css-transition.html');
- await page.goto('/');
- await page.getByRole('link', { name: /default/ }).click();
-
- await page.getByRole('button', { name: 'Interactive' }).click();
- await page.getByRole('button', { name: 'Pick locator' }).click();
- await expect(page.getByRole('button', { name: 'Pick locator' })).toHaveAttribute('aria-pressed', 'true');
- await expect(page.getByText('Click an element to pick its locator')).toBeVisible();
-
- await page.getByRole('button', { name: 'Read-only' }).click();
- await expect(page.getByRole('button', { name: 'Pick locator' })).toHaveAttribute('aria-pressed', 'false');
- await expect(page.getByText('Click an element to pick its locator')).toBeHidden();
-});
-
-test('copied locator toast clears on page change', async ({ cli, page, server, browserName }) => {
- server.setContent('/pick-locator-target.html', `<style>@keyframes a{0%{opacity:1}100%{opacity:.9}}</style><div id='picker-target' style='position:fixed; inset:0; background:red; animation:a 1s infinite'></div>`, 'text/html');
- server.setContent('/toast-next.html', `<title>Toast Next</title><h1>next</h1>`, 'text/html');
-
- await cli('open', server.PREFIX + '/pick-locator-target.html');
- await page.goto('/');
- if (browserName === 'chromium')
- await page.context().grantPermissions(['clipboard-read', 'clipboard-write']);
- await page.getByRole('link', { name: /default/ }).click();
-
- await page.getByRole('button', { name: 'Interactive' }).click();
- await page.getByRole('button', { name: 'Pick locator' }).click();
- await expect(page.getByRole('button', { name: 'Pick locator' })).toHaveAttribute('aria-pressed', 'true');
- await page.locator('.screen').click();
- await expect(page.getByText(/^Copied:/)).toBeVisible();
-
- await expect(page.getByRole('textbox', { name: 'Search or enter URL' })).toHaveValue(server.PREFIX + '/pick-locator-target.html');
- await page.getByRole('textbox', { name: 'Search or enter URL' }).fill(server.PREFIX + '/toast-next.html');
- await page.getByRole('textbox', { name: 'Search or enter URL' }).press('Enter');
-
- await expect(page.getByRole('tab', { name: 'Toast Next' })).toBeVisible();
- await expect(page.getByText(/^Copied:/)).toBeHidden();
-});
-
-test('close session while viewing devtools shows disconnected overlay', async ({ cli, page, server }) => {
- await cli('open', server.PREFIX + '/css-transition.html');
- await page.goto('/');
- await page.getByRole('link', { name: /default/ }).click();
- await expect(page.getByRole('button', { name: 'Interactive' })).toBeEnabled();
-
- await cli('close');
- await expect(page.getByText('Disconnected')).toBeVisible();
- await expect(page.getByRole('button', { name: 'Interactive' })).toBeDisabled();
-});
-
-test('running show twice gets same PID', async ({ cli }) => {
- const one = await cli('show', { env: { PWTEST_UNDER_TEST: '1' } });
- const two = await cli('show', { env: { PWTEST_UNDER_TEST: '1' } });
- expect(one.output).toEqual(two.output);
-});
-
-test('kill-all closes devtools', async ({ cli }) => {
- const one = await cli('show', { env: { PWTEST_UNDER_TEST: '1' } });
- await cli('kill-all');
- const two = await cli('show', { env: { PWTEST_UNDER_TEST: '1' } });
- expect(one.output).not.toEqual(two.output);
-});
diff --git a/tests/mcp/playwright.config.ts b/tests/mcp/playwright.config.ts
index eea2700a69..9087f29a48 100644
--- a/tests/mcp/playwright.config.ts
+++ b/tests/mcp/playwright.config.ts
@@ -54,9 +54,9 @@ export default defineConfig<TestOptions>({
tag: process.env.PW_TAG,
projects: [
{ name: 'chrome', metadata: { ...metadata, browserName: 'chromium', channel: 'chrome' }, testDir },
- { name: 'chromium', use: { mcpBrowser: 'chromium', browserName: 'chromium' }, metadata: { ...metadata, browserName: 'chromium' }, testDir },
- { name: 'firefox', use: { mcpBrowser: 'firefox', browserName: 'firefox' }, metadata: { ...metadata, browserName: 'firefox' }, testDir },
- { name: 'webkit', use: { mcpBrowser: 'webkit', browserName: 'webkit' }, metadata: { ...metadata, browserName: 'webkit' }, testDir },
- ... process.platform === 'win32' ? [{ name: 'msedge', use: { mcpBrowser: 'msedge', browserName: 'chromium' as const }, metadata: { ...metadata, browserName: 'chromium', channel: 'msedge' }, testDir }] : [],
+ { name: 'chromium', use: { mcpBrowser: 'chromium' }, metadata: { ...metadata, browserName: 'chromium' }, testDir },
+ { name: 'firefox', use: { mcpBrowser: 'firefox' }, metadata: { ...metadata, browserName: 'firefox' }, testDir },
+ { name: 'webkit', use: { mcpBrowser: 'webkit' }, metadata: { ...metadata, browserName: 'webkit' }, testDir },
+ ... process.platform === 'win32' ? [{ name: 'msedge', use: { mcpBrowser: 'msedge' }, metadata: { ...metadata, browserName: 'chromium', channel: 'msedge' }, testDir }] : [],
],
});