Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(tracing): add missing error handlers to createWriteStream pipes (#41227)
Sebastien Tardif08788271fd74
diff --git a/packages/playwright/src/reporters/html.ts b/packages/playwright/src/reporters/html.tsindex 6f9e05d844..8bc5cdc858 100644--- a/packages/playwright/src/reporters/html.ts+++ b/packages/playwright/src/reporters/html.ts@@ -464,11 +464,11 @@ class HtmlBuilder {private async _writeReportData(filePath: string) {fs.appendFileSync(filePath, '<template id="playwrightReportBase64">data:application/zip;base64,');- await new Promise(f => {+ await new Promise<void>((resolve, reject) => {this._dataZipFile.end(undefined, () => {this._dataZipFile.outputStream.pipe(new Base64Encoder())- .pipe(fs.createWriteStream(filePath, { flags: 'a' })).on('close', f);+ .pipe(fs.createWriteStream(filePath, { flags: 'a' })).on('close', resolve).on('error', reject);});});fs.appendFileSync(filePath, '</template>');diff --git a/packages/playwright/src/worker/testTracing.ts b/packages/playwright/src/worker/testTracing.tsindex 27132bc7fd..70b6a5c28e 100644--- a/packages/playwright/src/worker/testTracing.ts+++ b/packages/playwright/src/worker/testTracing.ts@@ -238,9 +238,9 @@ export class TestTracing {const traceContent = Buffer.from(this._traceEvents.map(e => JSON.stringify(e)).join('\n'));zipFile.addBuffer(traceContent, testTraceEntryName);- await new Promise(f => {+ await new Promise<void>((resolve, reject) => {zipFile.end(undefined, () => {- zipFile.outputStream.pipe(fs.createWriteStream(this._generateNextTraceRecordingPath())).on('close', f);+ zipFile.outputStream.pipe(fs.createWriteStream(this._generateNextTraceRecordingPath())).on('close', resolve).on('error', reject);});});