Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(ai snapshot): wait for blocking CSS (#36206)

Simon Knott090a4518662e
diff --git a/packages/playwright-core/src/server/page.ts b/packages/playwright-core/src/server/page.ts
index dc56433286..01392f7b1b 100644
--- a/packages/playwright-core/src/server/page.ts
+++ b/packages/playwright-core/src/server/page.ts
@@ -997,9 +997,15 @@ async function snapshotFrameForAI(metadata: CallMetadata, frame: frames.Frame, f
try {
const context = await frame._utilityContext();
const injectedScript = await context.injectedScript();
- return await injectedScript.evaluate((injected, refPrefix) => {
- return injected.ariaSnapshot(injected.document.body, { forAI: true, refPrefix });
+ const snapshotOrRetry = await injectedScript.evaluate((injected, refPrefix) => {
+ const node = injected.document.body;
+ if (!node)
+ return true;
+ return injected.ariaSnapshot(node, { forAI: true, refPrefix });
}, frameOrdinal ? 'f' + frameOrdinal : '');
+ if (snapshotOrRetry === true)
+ return continuePolling;
+ return snapshotOrRetry;
} catch (e) {
if (js.isJavaScriptErrorInEvaluate(e))
throw e;
diff --git a/tests/page/page-aria-snapshot-ai.spec.ts b/tests/page/page-aria-snapshot-ai.spec.ts
index d11716219e..35d591bf9f 100644
--- a/tests/page/page-aria-snapshot-ai.spec.ts
+++ b/tests/page/page-aria-snapshot-ai.spec.ts
@@ -240,3 +240,15 @@ it('should auto-wait for navigation', async ({ page, server }) => {
- generic [ref=e2]: Hi, I'm frame
`);
});
+
+it('should auto-wait for blocking CSS', async ({ page, server }) => {
+ server.setRoute('/css', (req, res) => {
+ res.setHeader('Content-Type', 'text/css');
+ setTimeout(() => res.end(`body { monospace }`), 1000);
+ });
+ await page.setContent(`
+ <script src="${server.PREFIX}/css"></script>
+ <p>Hello World</p>
+ `, { waitUntil: 'commit' });
+ expect(await snapshotForAI(page)).toContainYaml('Hello World');
+});