Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
test: fix a couple (#38869)
Dmitry Gozman0a35fbce221b
diff --git a/tests/library/beforeunload.spec.ts b/tests/library/beforeunload.spec.tsindex e39fdd2e32..c8e2ce30a8 100644--- a/tests/library/beforeunload.spec.ts+++ b/tests/library/beforeunload.spec.ts@@ -184,3 +184,27 @@ it('should support closing the page via a subsequent onbeforeunload dialog', asyawait page.waitForEvent('close');await expect(page.isClosed()).toBe(true);});++it('does not get stalled by beforeUnload', {+ annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/38731' },+}, async ({ page, server }) => {+ await page.goto(server.HELLO_WORLD);++ await page.evaluate(() => {+ window.addEventListener('beforeunload', event => {+ event.preventDefault();+ });+ });+ page.on('dialog', dialog => dialog.dismiss());++ // We have to interact with a page so that 'beforeunload' handlers+ // fire.+ await page.click('body');++ await page.route('**/api', route => route.fulfill({ status: 200, body: 'ok' }));+ await page.evaluate(async () => fetch(new URL('/api', window.location.href)));++ await page.close({ runBeforeUnload: true });++ await page.evaluate(async () => fetch(new URL('/api', window.location.href)));+});diff --git a/tests/page/page-route.spec.ts b/tests/page/page-route.spec.tsindex d0f2418e94..b601fc95fd 100644--- a/tests/page/page-route.spec.ts+++ b/tests/page/page-route.spec.ts@@ -1069,25 +1069,3 @@ it('should be able to intercept every navigation to a page controlled by serviceawait page.goto(URL);expect(interceptions).toBe(2);});--it('does not get stalled by beforeUnload', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/38731' } }, async ({ page, server }) => {- await page.goto(server.HELLO_WORLD);-- await page.evaluate(() => {- window.addEventListener('beforeunload', event => {- event.preventDefault();- });- });- page.on('dialog', dialog => dialog.dismiss());-- // We have to interact with a page so that 'beforeunload' handlers- // fire.- await page.click('body');-- await page.route('**/api', route => route.fulfill({ status: 200, body: 'ok' }));- await page.evaluate(async () => fetch(new URL('/api', window.location.href)));-- await page.close({ runBeforeUnload: true });-- await page.evaluate(async () => fetch(new URL('/api', window.location.href)));-});diff --git a/tests/playwright-test/playwright.spec.ts b/tests/playwright-test/playwright.spec.tsindex 666a5b6007..52300f66f0 100644--- a/tests/playwright-test/playwright.spec.ts+++ b/tests/playwright-test/playwright.spec.ts@@ -880,11 +880,11 @@ test('page.pause() should disable test timeout', async ({ runInlineTest }) => {import { test, expect } from '@playwright/test';test('test', async ({ page }) => {- test.setTimeout(2000);+ test.setTimeout(4000);await Promise.race([page.pause(),- new Promise(f => setTimeout(f, 3000)),+ new Promise(f => setTimeout(f, 5000)),]);console.log('success!');