Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

feat(trace-viewer): Show count in network details sections (#38323)

Chris0aae374121ff
diff --git a/packages/trace-viewer/src/ui/networkResourceDetails.css b/packages/trace-viewer/src/ui/networkResourceDetails.css
index fff88aa577..de65c5b3a6 100644
--- a/packages/trace-viewer/src/ui/networkResourceDetails.css
+++ b/packages/trace-viewer/src/ui/networkResourceDetails.css
@@ -39,6 +39,11 @@
font-weight: bold;
}
+.network-request-details-header-count {
+ color: var(--vscode-editorCodeLens-foreground);
+ font-weight: normal;
+}
+
.network-request-details-table {
width: 100%;
line-height: 18px;
diff --git a/packages/trace-viewer/src/ui/networkResourceDetails.tsx b/packages/trace-viewer/src/ui/networkResourceDetails.tsx
index cab1d9c3e2..b419434aa9 100644
--- a/packages/trace-viewer/src/ui/networkResourceDetails.tsx
+++ b/packages/trace-viewer/src/ui/networkResourceDetails.tsx
@@ -108,16 +108,21 @@ const CopyDropdown: React.FC<{
const ExpandableSection: React.FC<{
title: string;
+ showCount?: boolean,
data?: { name: string, value: React.ReactNode }[],
children?: React.ReactNode
className?: string;
-}> = ({ title, data, children, className }) => {
+}> = ({ title, data, showCount, children, className }) => {
const [expanded, setExpanded] = useSetting(`trace-viewer-network-details-${title.replaceAll(' ', '-')}`, true);
return <Expandable
expanded={expanded}
setExpanded={setExpanded}
expandOnTitleClick
- title={<span className='network-request-details-header'>{title}</span>}
+ title={
+ <span className='network-request-details-header'>{title}
+ {showCount && <span className='network-request-details-header-count'> × {data?.length ?? 0}</span>}
+ </span>
+ }
className={className}
>
{data && <table className='network-request-details-table'>
@@ -157,8 +162,8 @@ const RequestTab: React.FunctionComponent<{
return <div className='vbox network-request-details-tab'>
<ExpandableSection title='General' data={generalData}/>
- {resource.request.queryString.length > 0 && <ExpandableSection title='Query String Parameters' data={resource.request.queryString}/>}
- <ExpandableSection title='Request Headers' data={resource.request.headers}/>
+ {resource.request.queryString.length > 0 && <ExpandableSection title='Query String Parameters' showCount data={resource.request.queryString}/>}
+ <ExpandableSection title='Request Headers' showCount data={resource.request.headers}/>
<ExpandableSection title='Time' data={timeData}/>
{requestBody && <ExpandableSection title='Request Body' className='network-request-request-body'>
<CodeMirrorWrapper text={requestBody.text} mimeType={requestBody.mimeType} readOnly lineNumbers={true}/>
@@ -170,7 +175,7 @@ const ResponseTab: React.FunctionComponent<{
resource: ResourceSnapshot;
}> = ({ resource }) => {
return <div className='vbox network-request-details-tab'>
- <ExpandableSection title='Response Headers' data={resource.response.headers} />
+ <ExpandableSection title='Response Headers' showCount data={resource.response.headers} />
</div>;
};
diff --git a/tests/playwright-test/ui-mode-test-network-tab.spec.ts b/tests/playwright-test/ui-mode-test-network-tab.spec.ts
index 0e7014b5e7..0b74757cf7 100644
--- a/tests/playwright-test/ui-mode-test-network-tab.spec.ts
+++ b/tests/playwright-test/ui-mode-test-network-tab.spec.ts
@@ -196,7 +196,7 @@ test('should display list of query parameters (only if present)', async ({ runUI
await page.getByText('call-with-query-params').click();
- const region = page.getByRole('region', { name: 'Query String Parameters' });
+ const region = page.getByRole('region', { name: 'Query String Parameters × 3' });
await expect(region).toMatchAriaSnapshot(
`- table:
- rowgroup:
@@ -263,21 +263,21 @@ test('should toggle sections inside network details', async ({ runUITest, server
await page.getByRole('listitem').filter({ hasText: 'post-data-1' }).click();
const requestPanel = page.getByRole('tabpanel', { name: 'Request' });
- await requestPanel.getByRole('button', { name: 'Request Headers' }).click();
- await expect(requestPanel.getByRole('region', { name: 'Request Headers' })).toBeHidden();
+ await requestPanel.getByRole('button', { name: 'Request Headers × 16' }).click();
+ await expect(requestPanel.getByRole('region', { name: 'Request Headers × 16' })).toBeHidden();
await expect(requestPanel.getByRole('region', { name: 'Time' })).toHaveText(/Start.+Duration\d+ms/);
await requestPanel.getByRole('button', { name: 'Time' }).click();
- await expect(requestPanel.getByRole('region', { name: 'Request Headers' })).toBeHidden();
+ await expect(requestPanel.getByRole('region', { name: 'Request Headers × 16' })).toBeHidden();
await expect(requestPanel.getByRole('region', { name: 'Time' })).toBeHidden();
await requestPanel.getByRole('button', { name: 'Time' }).click();
- await expect(requestPanel.getByRole('region', { name: 'Request Headers' })).toBeHidden();
+ await expect(requestPanel.getByRole('region', { name: 'Request Headers × 16' })).toBeHidden();
await expect(requestPanel.getByRole('region', { name: 'Time' })).toHaveText(/Start.+Duration\d+ms/);
// Re-opening should preserve open state
await page.getByRole('tabpanel', { name: 'Network' }).getByRole('button', { name: 'Close' }).click();
await page.getByRole('listitem').filter({ hasText: 'post-data-1' }).click();
- await expect(requestPanel.getByRole('region', { name: 'Request Headers' })).toBeHidden();
+ await expect(requestPanel.getByRole('region', { name: 'Request Headers × 16' })).toBeHidden();
await expect(requestPanel.getByRole('region', { name: 'Time' })).toHaveText(/Start.+Duration\d+ms/);
});