Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: unship clock.uninstall (#37020)

Dmitry Gozman0c813daf1a1f
diff --git a/docs/src/api/class-clock.md b/docs/src/api/class-clock.md
index 6b199e4685..e5610b4242 100644
--- a/docs/src/api/class-clock.md
+++ b/docs/src/api/class-clock.md
@@ -340,8 +340,3 @@ Time to be set.
- `time` <[string]|[Date]>
Time to be set.
-
-## async method: Clock.uninstall
-* since: v1.55
-
-Uninstall fake clock. Note that any currently open page will be still affected by the fake clock, until it navigates away to a new document.
diff --git a/packages/playwright-client/types/types.d.ts b/packages/playwright-client/types/types.d.ts
index d210fe14c9..cc18a9ec89 100644
--- a/packages/playwright-client/types/types.d.ts
+++ b/packages/playwright-client/types/types.d.ts
@@ -18798,12 +18798,6 @@ export interface Clock {
* @param time Time to be set in milliseconds.
*/
setSystemTime(time: number|string|Date): Promise<void>;
-
- /**
- * Uninstall fake clock. Note that any currently open page will be still affected by the fake clock, until it
- * navigates away to a new document.
- */
- uninstall(): Promise<void>;
}
/**
diff --git a/packages/playwright-core/src/client/clock.ts b/packages/playwright-core/src/client/clock.ts
index e9622c272a..fdc7789b59 100644
--- a/packages/playwright-core/src/client/clock.ts
+++ b/packages/playwright-core/src/client/clock.ts
@@ -51,10 +51,6 @@ export class Clock implements api.Clock {
async setSystemTime(time: string | number | Date) {
await this._browserContext._channel.clockSetSystemTime(parseTime(time));
}
-
- async uninstall() {
- await this._browserContext._channel.clockUninstall();
- }
}
function parseTime(time: string | number | Date): { timeNumber?: number, timeString?: string } {
diff --git a/packages/playwright-core/src/protocol/validator.ts b/packages/playwright-core/src/protocol/validator.ts
index f9174d120d..f704da03f4 100644
--- a/packages/playwright-core/src/protocol/validator.ts
+++ b/packages/playwright-core/src/protocol/validator.ts
@@ -1158,8 +1158,6 @@ scheme.BrowserContextClockSetSystemTimeParams = tObject({
timeString: tOptional(tString),
});
scheme.BrowserContextClockSetSystemTimeResult = tOptional(tObject({}));
-scheme.BrowserContextClockUninstallParams = tOptional(tObject({}));
-scheme.BrowserContextClockUninstallResult = tOptional(tObject({}));
scheme.PageInitializer = tObject({
mainFrame: tChannel(['Frame']),
viewportSize: tOptional(tObject({
diff --git a/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts b/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
index 9a1e90534f..cc779595e1 100644
--- a/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
+++ b/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
@@ -400,10 +400,6 @@ export class BrowserContextDispatcher extends Dispatcher<BrowserContext, channel
await this._context.clock.setSystemTime(progress, params.timeString ?? params.timeNumber ?? 0);
}
- async clockUninstall(params: channels.BrowserContextClockUninstallParams, progress: Progress): Promise<channels.BrowserContextClockUninstallResult> {
- await this._context.clock.uninstall(progress);
- }
-
async updateSubscription(params: channels.BrowserContextUpdateSubscriptionParams, progress: Progress): Promise<void> {
if (params.enabled)
this._subscriptions.add(params.event);
diff --git a/packages/playwright-core/src/utils/isomorphic/protocolMetainfo.ts b/packages/playwright-core/src/utils/isomorphic/protocolMetainfo.ts
index ba40cce6e8..13646ce5ba 100644
--- a/packages/playwright-core/src/utils/isomorphic/protocolMetainfo.ts
+++ b/packages/playwright-core/src/utils/isomorphic/protocolMetainfo.ts
@@ -97,7 +97,6 @@ export const methodMetainfo = new Map<string, { internal?: boolean, title?: stri
['BrowserContext.clockRunFor', { title: 'Run clock "{ticksNumber|ticksString}"', }],
['BrowserContext.clockSetFixedTime', { title: 'Set fixed time "{timeNumber|timeString}"', }],
['BrowserContext.clockSetSystemTime', { title: 'Set system time "{timeNumber|timeString}"', }],
- ['BrowserContext.clockUninstall', { title: 'Uninstall clock', }],
['Page.addInitScript', { title: 'Add init script', group: 'configuration', }],
['Page.close', { title: 'Close page', pausesBeforeAction: true, }],
['Page.emulateMedia', { title: 'Emulate media', snapshot: true, pausesBeforeAction: true, }],
diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.ts
index d210fe14c9..cc18a9ec89 100644
--- a/packages/playwright-core/types/types.d.ts
+++ b/packages/playwright-core/types/types.d.ts
@@ -18798,12 +18798,6 @@ export interface Clock {
* @param time Time to be set in milliseconds.
*/
setSystemTime(time: number|string|Date): Promise<void>;
-
- /**
- * Uninstall fake clock. Note that any currently open page will be still affected by the fake clock, until it
- * navigates away to a new document.
- */
- uninstall(): Promise<void>;
}
/**
diff --git a/packages/protocol/src/channels.d.ts b/packages/protocol/src/channels.d.ts
index 33fce000bf..10749d68c6 100644
--- a/packages/protocol/src/channels.d.ts
+++ b/packages/protocol/src/channels.d.ts
@@ -1627,7 +1627,6 @@ export interface BrowserContextChannel extends BrowserContextEventTarget, EventT
clockRunFor(params: BrowserContextClockRunForParams, progress?: Progress): Promise<BrowserContextClockRunForResult>;
clockSetFixedTime(params: BrowserContextClockSetFixedTimeParams, progress?: Progress): Promise<BrowserContextClockSetFixedTimeResult>;
clockSetSystemTime(params: BrowserContextClockSetSystemTimeParams, progress?: Progress): Promise<BrowserContextClockSetSystemTimeResult>;
- clockUninstall(params?: BrowserContextClockUninstallParams, progress?: Progress): Promise<BrowserContextClockUninstallResult>;
}
export type BrowserContextBindingCallEvent = {
binding: BindingCallChannel,
@@ -2006,9 +2005,6 @@ export type BrowserContextClockSetSystemTimeOptions = {
timeString?: string,
};
export type BrowserContextClockSetSystemTimeResult = void;
-export type BrowserContextClockUninstallParams = {};
-export type BrowserContextClockUninstallOptions = {};
-export type BrowserContextClockUninstallResult = void;
export interface BrowserContextEvents {
'bindingCall': BrowserContextBindingCallEvent;
diff --git a/packages/protocol/src/protocol.yml b/packages/protocol/src/protocol.yml
index 440d0c5a32..b6ab404173 100644
--- a/packages/protocol/src/protocol.yml
+++ b/packages/protocol/src/protocol.yml
@@ -1470,9 +1470,6 @@ BrowserContext:
timeNumber: float?
timeString: string?
- clockUninstall:
- title: Uninstall clock
-
events:
bindingCall:
diff --git a/tests/library/page-clock.spec.ts b/tests/library/page-clock.spec.ts
index 8545f8ef67..277ec46726 100644
--- a/tests/library/page-clock.spec.ts
+++ b/tests/library/page-clock.spec.ts
@@ -565,16 +565,3 @@ it('correctly increments Date.now()/performance.now() during blocking execution'
await page.goto(server.PREFIX + '/repro.html');
await waitForDone;
});
-
-it('should uninstall', async ({ page }) => {
- await page.clock.install({ time: 0 });
- await page.clock.pauseAt(1000);
- expect(await page.evaluate(() => Date.now())).toBe(1000);
-
- await page.goto('about:blank');
- expect(await page.evaluate(() => Date.now())).toBe(1000);
-
- await page.clock.uninstall();
- await page.goto('about:blank');
- expect(await page.evaluate(() => Date.now())).not.toBe(1000);
-});