Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore: use non-aria visibility for ai snapshots (#37194)
Pavel Feldman0c92f5e5f77b
diff --git a/packages/injected/src/ariaSnapshot.ts b/packages/injected/src/ariaSnapshot.tsindex 8c06d9e2e3..1fcde61224 100644--- a/packages/injected/src/ariaSnapshot.ts+++ b/packages/injected/src/ariaSnapshot.ts@@ -54,7 +54,7 @@ export type AriaTreeOptions = {};type InternalOptions = {- visibility: 'aria' | 'ariaOrVisible' | 'ariaAndVisible',+ visibility: 'aria' | 'visible' | 'ariaAndVisible',refs: 'all' | 'interactable' | 'none',refPrefix?: string,includeGenericRole?: boolean,@@ -67,7 +67,7 @@ function toInternalOptions(options: AriaTreeOptions): InternalOptions {if (options.mode === 'ai') {// For AI consumption.return {- visibility: 'ariaOrVisible',+ visibility: 'visible',refs: 'interactable',refPrefix: options.refPrefix,includeGenericRole: true,@@ -119,8 +119,8 @@ export function generateAriaTree(rootElement: Element, publicOptions: AriaTreeOpconst element = node as Element;const isElementVisibleForAria = !roleUtils.isElementHiddenForAria(element);let visible = isElementVisibleForAria;- if (options.visibility === 'ariaOrVisible')- visible = isElementVisibleForAria || isElementVisible(element);+ if (options.visibility === 'visible')+ visible = isElementVisible(element);if (options.visibility === 'ariaAndVisible')visible = isElementVisibleForAria && isElementVisible(element);diff --git a/tests/page/page-aria-snapshot-ai.spec.ts b/tests/page/page-aria-snapshot-ai.spec.tsindex c7afd03cf3..86b6f344ad 100644--- a/tests/page/page-aria-snapshot-ai.spec.ts+++ b/tests/page/page-aria-snapshot-ai.spec.ts@@ -17,7 +17,7 @@// @ts-ignoreimport { asLocator } from 'playwright-core/lib/utils';-import { test as it, expect, unshift } from './pageTest';+import { test as it, expect } from './pageTest';function snapshotForAI(page: any, options?: { timeout?: number }): Promise<string> {return page._snapshotForAI(options);@@ -184,18 +184,9 @@ it('emit generic roles for nodes w/o roles', async ({ page }) => {expect(snapshot).toContainYaml(`- generic [ref=e2]:- - generic [ref=e3]:- - generic [ref=e4]:- - radio "Apple" [checked]- - generic [ref=e5]: Apple- - generic [ref=e6]:- - generic [ref=e7]:- - radio "Pear"- - generic [ref=e8]: Pear- - generic [ref=e9]:- - generic [ref=e10]:- - radio "Orange"- - generic [ref=e11]: Orange+ - generic [ref=e5]: Apple+ - generic [ref=e8]: Pear+ - generic [ref=e11]: Orange`);});@@ -281,11 +272,11 @@ it('should show visible children of hidden elements', { annotation: { type: 'iss</div>`);- expect(await snapshotForAI(page)).toEqual(unshift(`+ expect(await snapshotForAI(page)).toContainYaml(`- generic [active] [ref=e1]:- button "Visible" [ref=e3]- button "Visible" [ref=e4]- `));+ `);});it('should include active element information', async ({ page }) => {