Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore: remove FullConfig.failOnFlakyTests (#35541)
Dmitry Gozman0e964e2b99f1
diff --git a/docs/src/test-api/class-fullconfig.md b/docs/src/test-api/class-fullconfig.mdindex fe80475ed6..edbc991bfd 100644--- a/docs/src/test-api/class-fullconfig.md+++ b/docs/src/test-api/class-fullconfig.md@@ -10,12 +10,6 @@ Resolved configuration which is accessible via [`property: TestInfo.config`] andPath to the configuration file used to run the tests. The value is an empty string if no config file was used.-## property: FullConfig.failOnFlakyTests-* since: v1.52-- type: <[boolean]>--See [`property: TestConfig.failOnFlakyTests`].-## property: FullConfig.forbidOnly* since: v1.10- type: <[boolean]>diff --git a/packages/playwright/src/common/config.ts b/packages/playwright/src/common/config.tsindex ddc834e07e..d7c1854211 100644--- a/packages/playwright/src/common/config.ts+++ b/packages/playwright/src/common/config.ts@@ -48,6 +48,7 @@ export class FullConfigInternal {readonly projects: FullProjectInternal[] = [];readonly singleTSConfigPath?: string;readonly captureGitInfo: Config['captureGitInfo'];+ readonly failOnFlakyTests: boolean;cliArgs: string[] = [];cliGrep: string | undefined;cliGrepInvert: string | undefined;@@ -77,6 +78,7 @@ export class FullConfigInternal {this.plugins = (privateConfiguration?.plugins || []).map((p: any) => ({ factory: p }));this.singleTSConfigPath = pathResolve(configDir, userConfig.tsconfig);this.captureGitInfo = userConfig.captureGitInfo;+ this.failOnFlakyTests = takeFirst(configCLIOverrides.failOnFlakyTests, userConfig.failOnFlakyTests, false);this.globalSetups = (Array.isArray(userConfig.globalSetup) ? userConfig.globalSetup : [userConfig.globalSetup]).map(s => resolveScript(s, configDir)).filter(script => script !== undefined);this.globalTeardowns = (Array.isArray(userConfig.globalTeardown) ? userConfig.globalTeardown : [userConfig.globalTeardown]).map(s => resolveScript(s, configDir)).filter(script => script !== undefined);@@ -88,7 +90,6 @@ export class FullConfigInternal {this.config = {configFile: resolvedConfigFile,rootDir: pathResolve(configDir, userConfig.testDir) || configDir,- failOnFlakyTests: takeFirst(configCLIOverrides.failOnFlakyTests, userConfig.failOnFlakyTests, false),forbidOnly: takeFirst(configCLIOverrides.forbidOnly, userConfig.forbidOnly, false),fullyParallel: takeFirst(configCLIOverrides.fullyParallel, userConfig.fullyParallel, false),globalSetup: this.globalSetups[0] ?? null,diff --git a/packages/playwright/src/isomorphic/teleReceiver.ts b/packages/playwright/src/isomorphic/teleReceiver.tsindex 8f22a55d84..e657813067 100644--- a/packages/playwright/src/isomorphic/teleReceiver.ts+++ b/packages/playwright/src/isomorphic/teleReceiver.ts@@ -607,7 +607,6 @@ export class TeleTestResult implements reporterTypes.TestResult {export type TeleFullProject = reporterTypes.FullProject;export const baseFullConfig: reporterTypes.FullConfig = {- failOnFlakyTests: false,forbidOnly: false,fullyParallel: false,globalSetup: null,diff --git a/packages/playwright/src/runner/failureTracker.ts b/packages/playwright/src/runner/failureTracker.tsindex afc4548a66..dd8ce50587 100644--- a/packages/playwright/src/runner/failureTracker.ts+++ b/packages/playwright/src/runner/failureTracker.ts@@ -49,7 +49,7 @@ export class FailureTracker {}result(): 'failed' | 'passed' {- return this._hasWorkerErrors || this.hasReachedMaxFailures() || this.hasFailedTests() || (this._config.config.failOnFlakyTests && this.hasFlakyTests()) ? 'failed' : 'passed';+ return this._hasWorkerErrors || this.hasReachedMaxFailures() || this.hasFailedTests() || (this._config.failOnFlakyTests && this.hasFlakyTests()) ? 'failed' : 'passed';}hasFailedTests() {diff --git a/packages/playwright/types/test.d.ts b/packages/playwright/types/test.d.tsindex a8366fd3c0..c349529c0e 100644--- a/packages/playwright/types/test.d.ts+++ b/packages/playwright/types/test.d.ts@@ -1930,12 +1930,6 @@ export interface FullConfig<TestArgs = {}, WorkerArgs = {}> {*/configFile?: string;- /**- * See- * [testConfig.failOnFlakyTests](https://playwright.dev/docs/api/class-testconfig#test-config-fail-on-flaky-tests).- */- failOnFlakyTests: boolean;-/*** See [testConfig.forbidOnly](https://playwright.dev/docs/api/class-testconfig#test-config-forbid-only).*/