Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
revert(#35684): select options can be invisible (#35687)
Pavel Feldman11f2ce7d3bd8
diff --git a/packages/injected/src/ariaSnapshot.ts b/packages/injected/src/ariaSnapshot.tsindex 17de28ecbf..9c87d38fc1 100644--- a/packages/injected/src/ariaSnapshot.ts+++ b/packages/injected/src/ariaSnapshot.ts@@ -17,7 +17,7 @@import { Map, Set } from '@isomorphic/builtins';import { escapeRegExp, longestCommonSubstring, normalizeWhiteSpace } from '@isomorphic/stringUtils';-import { getElementComputedStyle, getGlobalOptions, isElementVisible } from './domUtils';+import { getElementComputedStyle, getGlobalOptions } from './domUtils';import * as roleUtils from './roleUtils';import { yamlEscapeKeyIfNeeded, yamlEscapeValueIfNeeded } from './yaml';@@ -86,10 +86,6 @@ export function generateAriaTree(rootElement: Element, generation: number, optio}}- // Skip all the leaf nodes that are not visible as they can't be interacted with.- if (!ariaChildren.length && !isElementVisible(element))- return;-addElement(element);const childAriaNode = toAriaNode(element, options);if (childAriaNode)diff --git a/tests/library/inspector/cli-codegen-aria.spec.ts b/tests/library/inspector/cli-codegen-aria.spec.tsindex 9a81f25f73..a11cf33342 100644--- a/tests/library/inspector/cli-codegen-aria.spec.ts+++ b/tests/library/inspector/cli-codegen-aria.spec.ts@@ -68,6 +68,7 @@ test.describe(() => {await recorder.trustedClick();await recorder.recorderPage.getByRole('tab', { name: 'Aria' }).click();await expect(recorder.recorderPage.locator('.tab-aria .CodeMirror')).toMatchAriaSnapshot(`+ - textbox- text: '- button "Submit"'`);});diff --git a/tests/page/page-aria-snapshot.spec.ts b/tests/page/page-aria-snapshot.spec.tsindex c52dd68df1..809d419eec 100644--- a/tests/page/page-aria-snapshot.spec.ts+++ b/tests/page/page-aria-snapshot.spec.ts@@ -731,18 +731,6 @@ it('ref mode can be used to stitch all frame snapshots', async ({ page, server }`.trim());});-it('should not include hidden input elements', async ({ page }) => {- await page.setContent(`- <button>One</button>- <button style="width: 0; height: 0; appearance: none; border: 0; padding: 0;">Two</button>- <button>Three</button>- `);-- const snapshot = await page.locator('body').ariaSnapshot();- expect(snapshot).toContain(`- button \"One\"-- button \"Three\"`);-});-it('emit generic roles for nodes w/o roles', async ({ page }) => {await page.setContent(`<style>@@ -754,21 +742,12 @@ it('emit generic roles for nodes w/o roles', async ({ page }) => {</style><div><label>- <span>- <input type="radio" value="Apple" checked="">- </span><span>Apple</span></label><label>- <span>- <input type="radio" value="Pear">- </span><span>Pear</span></label><label>- <span>- <input type="radio" value="Orange">- </span><span>Orange</span></label></div>