Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(bidi): remove stringified exceptionDetails from error messages (#37470)

Holger Benl1408667001ef
diff --git a/packages/playwright-core/src/server/bidi/bidiExecutionContext.ts b/packages/playwright-core/src/server/bidi/bidiExecutionContext.ts
index 33a2890bfb..c7e0a745eb 100644
--- a/packages/playwright-core/src/server/bidi/bidiExecutionContext.ts
+++ b/packages/playwright-core/src/server/bidi/bidiExecutionContext.ts
@@ -57,7 +57,7 @@ export class BidiExecutionContext implements js.ExecutionContextDelegate {
if (response.type === 'success')
return BidiDeserializer.deserialize(response.result);
if (response.type === 'exception')
- throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text + '\nFull val: ' + JSON.stringify(response.exceptionDetails));
+ throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text);
throw new js.JavaScriptErrorInEvaluate('Unexpected response type: ' + JSON.stringify(response));
}
@@ -76,7 +76,7 @@ export class BidiExecutionContext implements js.ExecutionContextDelegate {
throw new js.JavaScriptErrorInEvaluate('Cannot get handle: ' + JSON.stringify(response.result));
}
if (response.type === 'exception')
- throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text + '\nFull val: ' + JSON.stringify(response.exceptionDetails));
+ throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text);
throw new js.JavaScriptErrorInEvaluate('Unexpected response type: ' + JSON.stringify(response));
}
@@ -95,7 +95,7 @@ export class BidiExecutionContext implements js.ExecutionContextDelegate {
userActivation: true,
});
if (response.type === 'exception')
- throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text + '\nFull val: ' + JSON.stringify(response.exceptionDetails));
+ throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text);
if (response.type === 'success') {
if (returnByValue)
return parseEvaluationResultValue(BidiDeserializer.deserialize(response.result));
@@ -180,7 +180,7 @@ export class BidiExecutionContext implements js.ExecutionContextDelegate {
userActivation: true,
});
if (response.type === 'exception')
- throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text + '\nFull val: ' + JSON.stringify(response.exceptionDetails));
+ throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text);
if (response.type === 'success')
return response.result;
throw new js.JavaScriptErrorInEvaluate('Unexpected response type: ' + JSON.stringify(response));