Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: make installing non-hermetic browsers idempotent (#35791)

Simon Knott1924b51d3f53
diff --git a/packages/playwright-core/src/server/registry/index.ts b/packages/playwright-core/src/server/registry/index.ts
index 4dfb63b98e..4cbd7b5c89 100644
--- a/packages/playwright-core/src/server/registry/index.ts
+++ b/packages/playwright-core/src/server/registry/index.ts
@@ -1053,7 +1053,7 @@ export class Registry {
const { embedderName } = getEmbedderName();
if (!getAsBooleanFromENV('CI') && !executable._isHermeticInstallation && !forceReinstall && executable.executablePath(embedderName)) {
const command = buildPlaywrightCLICommand(embedderName, 'install --force ' + executable.name);
- throw new Error('\n' + wrapInASCIIBox([
+ process.stderr.write('\n' + wrapInASCIIBox([
`ATTENTION: "${executable.name}" is already installed on the system!`,
``,
`"${executable.name}" installation is not hermetic; installing newer version`,
@@ -1067,7 +1067,8 @@ export class Registry {
` ${command}`,
``,
`<3 Playwright Team`,
- ].join('\n'), 1));
+ ].join('\n'), 1) + '\n\n');
+ return;
}
await executable._install();
}