Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: fix android socket on('close') (#36293)

Dmitry Gozman19718c0ab680
diff --git a/packages/playwright-core/src/server/dispatchers/androidDispatcher.ts b/packages/playwright-core/src/server/dispatchers/androidDispatcher.ts
index fb552b9809..cce5f325d1 100644
--- a/packages/playwright-core/src/server/dispatchers/androidDispatcher.ts
+++ b/packages/playwright-core/src/server/dispatchers/androidDispatcher.ts
@@ -181,7 +181,10 @@ class SocketSdkObject extends SdkObject implements SocketBackend {
this._socket = socket;
this._eventListeners = [
eventsHelper.addEventListener(socket, 'data', data => this.emit('data', data)),
- eventsHelper.addEventListener(socket, 'close', () => this.emit('close')),
+ eventsHelper.addEventListener(socket, 'close', () => {
+ eventsHelper.removeEventListeners(this._eventListeners);
+ this.emit('close');
+ }),
];
}
@@ -191,7 +194,6 @@ class SocketSdkObject extends SdkObject implements SocketBackend {
close() {
this._socket.close();
- eventsHelper.removeEventListeners(this._eventListeners);
}
}