Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix: clamp setTimeout value to prevent negative timeout crash (#39273)

Varun Chawla1a4fa19a3889
diff --git a/packages/playwright-core/src/utils/isomorphic/timeoutRunner.ts b/packages/playwright-core/src/utils/isomorphic/timeoutRunner.ts
index 9a01d0f079..d551ee2033 100644
--- a/packages/playwright-core/src/utils/isomorphic/timeoutRunner.ts
+++ b/packages/playwright-core/src/utils/isomorphic/timeoutRunner.ts
@@ -29,9 +29,9 @@ export async function raceAgainstDeadline<T>(cb: () => Promise<T>, deadline: num
return { result, timedOut: false };
}),
new Promise<{ timedOut: true }>(resolve => {
- const kMaxDeadline = 2147483647; // 2^31-1
- const timeout = (deadline || kMaxDeadline) - monotonicTime();
- timer = setTimeout(() => resolve({ timedOut: true }), timeout);
+ if (!deadline)
+ return;
+ timer = setTimeout(() => resolve({ timedOut: true }), deadline - monotonicTime());
}),
]).finally(() => {
clearTimeout(timer);