Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: fix context._disableRecorder (#37685)

Dmitry Gozman258b4dcb1972
diff --git a/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts b/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
index 4b32fbd9b8..4555d4c101 100644
--- a/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
+++ b/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
@@ -327,7 +327,7 @@ export class BrowserContextDispatcher extends Dispatcher<BrowserContext, channel
}
async disableRecorder(params: channels.BrowserContextDisableRecorderParams, progress: Progress): Promise<void> {
- const recorder = Recorder.existingForContext(this._context);
+ const recorder = await Recorder.existingForContext(this._context);
if (recorder)
recorder.setMode('none');
}
diff --git a/packages/playwright-core/src/server/recorder.ts b/packages/playwright-core/src/server/recorder.ts
index ebd738c648..cb29fcfd3a 100644
--- a/packages/playwright-core/src/server/recorder.ts
+++ b/packages/playwright-core/src/server/recorder.ts
@@ -100,8 +100,9 @@ export class Recorder extends EventEmitter<RecorderEventMap> implements Instrume
return recorderPromise;
}
- static existingForContext(context: BrowserContext): Recorder | undefined {
- return (context as any)[recorderSymbol] as Recorder;
+ static async existingForContext(context: BrowserContext): Promise<Recorder | undefined> {
+ const recorderPromise = (context as any)[recorderSymbol] as Promise<Recorder> | undefined;
+ return await recorderPromise;
}
private static async _create(context: BrowserContext, params: channels.BrowserContextEnableRecorderParams = {}): Promise<Recorder> {
diff --git a/tests/library/inspector/recorder-api.spec.ts b/tests/library/inspector/recorder-api.spec.ts
index 25e7f0694d..d195e8cfb8 100644
--- a/tests/library/inspector/recorder-api.spec.ts
+++ b/tests/library/inspector/recorder-api.spec.ts
@@ -139,3 +139,15 @@ test('should type', async ({ context }) => {
expect(normalizeCode(fillActions[0].code)).toEqual(`await page.getByRole('textbox').fill('Hello');`);
});
+
+test('should disable recorder', async ({ context }) => {
+ const log = await startRecording(context);
+ const page = await context.newPage();
+ await page.setContent(`<button onclick="console.log('click')">Submit</button>`);
+ await page.getByRole('button', { name: 'Submit' }).click();
+ await page.getByRole('button', { name: 'Submit' }).click();
+ expect(log.action('click')).toHaveLength(2);
+ await (context as any)._disableRecorder();
+ await page.getByRole('button', { name: 'Submit' }).click();
+ expect(log.action('click')).toHaveLength(2);
+});