Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(proxy): do not force loopback proxy when bypass list includes localhost (#39566)
Pavel Feldman28c39dc7d810
diff --git a/.claude/skills/playwright-dev/SKILL.md b/.claude/skills/playwright-dev/SKILL.mdindex 25cf694ca1..e169d33c7c 100644--- a/.claude/skills/playwright-dev/SKILL.md+++ b/.claude/skills/playwright-dev/SKILL.md@@ -11,6 +11,7 @@ description: Explains how to develop Playwright - add APIs, MCP tools, CLI comma- [Adding and Modifying APIs](api.md) — define API docs, implement client/server, add tests- [MCP Tools and CLI Commands](mcp-dev.md) — add MCP tools, CLI commands, config options- [Vendoring Dependencies](vendor.md) — bundle third-party npm packages into playwright-core or playwright+- [Uploading Fixes to GitHub](github.md) — branch naming, commit format, pushing fixes for issues## Build- Assume watch is running and everything is up to date.diff --git a/.claude/skills/playwright-dev/github.md b/.claude/skills/playwright-dev/github.mdnew file mode 100644index 0000000000..ff59e14261--- /dev/null+++ b/.claude/skills/playwright-dev/github.md@@ -0,0 +1,56 @@+# Uploading a Fix for a GitHub Issue++## Branch naming++Create a branch named after the issue number:++```+git checkout -b fix-39562+```++## Committing changes++Use conventional commit format with a scope:++- `fix(proxy): description` — bug fixes+- `feat(locator): description` — new features+- `chore(cli): description` — maintenance, refactoring, tests++The commit body must be a single line: `Fixes: https://github.com/microsoft/playwright/issues/39562`++Stage only the files related to the fix. Do not use `git add -A` or `git add .`.++```+git add src/server/proxy.ts tests/proxy.spec.ts+git commit -m "$(cat <<'EOF'+fix(proxy): handle SOCKS proxy authentication++Fixes: https://github.com/microsoft/playwright/issues/39562+EOF+)"+```++## Pushing++Push the branch to origin:++```+git push origin fix-39562+```++## Full example++For issue https://github.com/microsoft/playwright/issues/39562:++```bash+git checkout -b fix-39562+# ... make changes ...+git add <changed-files>+git commit -m "$(cat <<'EOF'+fix(proxy): handle SOCKS proxy authentication++Fixes: https://github.com/microsoft/playwright/issues/39562+EOF+)"+git push origin fix-39562+```diff --git a/packages/playwright-core/src/server/chromium/chromium.ts b/packages/playwright-core/src/server/chromium/chromium.tsindex 04b6c01053..f0b955c13c 100644--- a/packages/playwright-core/src/server/chromium/chromium.ts+++ b/packages/playwright-core/src/server/chromium/chromium.ts@@ -349,7 +349,8 @@ export class Chromium extends BrowserType {proxyBypassRules.push('<-loopback>');if (proxy.bypass)proxyBypassRules.push(...proxy.bypass.split(',').map(t => t.trim()).map(t => t.startsWith('.') ? '*' + t : t));- if (!process.env.PLAYWRIGHT_DISABLE_FORCED_CHROMIUM_PROXIED_LOOPBACK && !proxyBypassRules.includes('<-loopback>'))+ const bypassesLoopback = proxyBypassRules.some(rule => rule === '<-loopback>' || rule === 'localhost' || rule === '127.0.0.1' || rule === '::1');+ if (!process.env.PLAYWRIGHT_DISABLE_FORCED_CHROMIUM_PROXIED_LOOPBACK && !bypassesLoopback)proxyBypassRules.push('<-loopback>');if (proxyBypassRules.length > 0)chromeArguments.push(`--proxy-bypass-list=${proxyBypassRules.join(';')}`);diff --git a/tests/library/proxy.spec.ts b/tests/library/proxy.spec.tsindex 9f068fcb01..97cfeaf5a0 100644--- a/tests/library/proxy.spec.ts+++ b/tests/library/proxy.spec.ts@@ -228,6 +228,22 @@ it('should exclude patterns', async ({ browserType, server, channel }) => {await browser.close();});+it('should bypass proxy for localhost when localhost is in bypass list', async ({ browserType, server, proxyServer }) => {+ proxyServer.forwardTo(server.PORT);+ server.setRoute('/target.html', async (req, res) => {+ res.end('<html><title>Served by the proxy</title></html>');+ });+ const browser = await browserType.launch({+ proxy: { server: `localhost:${proxyServer.PORT}`, bypass: 'localhost' }+ });+ const page = await browser.newPage();+ // Navigate to localhost - should bypass the proxy and hit the server directly.+ await page.goto(`http://localhost:${server.PORT}/target.html`);+ expect(proxyServer.requestUrls).not.toContain(`http://localhost:${server.PORT}/target.html`);+ expect(await page.title()).toBe('Served by the proxy');+ await browser.close();+});+it('should use socks proxy', async ({ browserType, socksPort }) => {const browser = await browserType.launch({proxy: { server: `socks5://localhost:${socksPort}` }