Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

test(download): ensure HTTP_PROXY is unused (#37645)

Simon Knott2900aebf23e5
diff --git a/tests/installation/playwright-cli-install-should-work.spec.ts b/tests/installation/playwright-cli-install-should-work.spec.ts
index 4e068a2412..c3116aae37 100755
--- a/tests/installation/playwright-cli-install-should-work.spec.ts
+++ b/tests/installation/playwright-cli-install-should-work.spec.ts
@@ -61,7 +61,7 @@ test('install command should work', async ({ exec, checkInstalledSoftwareOnDisk
}
});
-test('install command should work with proxy', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/36650' } }, async ({ exec, checkInstalledSoftwareOnDisk }) => {
+test('install command should work with HTTPS_PROXY', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/36650' } }, async ({ exec, checkInstalledSoftwareOnDisk }) => {
await exec('npm i playwright');
const proxy = await TestProxy.create(8947 + test.info().workerIndex * 4);
proxy.forwardTo(443, { preserveHostname: true });
@@ -77,6 +77,19 @@ test('install command should work with proxy', { annotation: { type: 'issue', de
await proxy.stop();
});
+test('install command should ignore HTTP_PROXY', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/36412' } }, async ({ exec, checkInstalledSoftwareOnDisk }) => {
+ await exec('npm i playwright');
+ await test.step('playwright install chromium', async () => {
+ const result = await exec('npx playwright install chromium', {
+ env: {
+ HTTP_PROXY: 'unused',
+ },
+ });
+ expect(result).toHaveLoggedSoftwareDownload(['chromium', 'chromium-headless-shell', 'ffmpeg', ...extraInstalledSoftware]);
+ await checkInstalledSoftwareOnDisk(['chromium', 'chromium-headless-shell', 'ffmpeg', ...extraInstalledSoftware]);
+ });
+});
+
test('should be able to remove browsers', async ({ exec, checkInstalledSoftwareOnDisk }) => {
await exec('npm i playwright');
await exec('npx playwright install chromium');