Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(trace-viewer): use button elements for network filter tabs (#41489)

Aditya Kumar Gupta2c6686102f08
diff --git a/packages/trace-viewer/src/ui/networkFilters.css b/packages/trace-viewer/src/ui/networkFilters.css
index 836c7102c9..3f0883a60d 100644
--- a/packages/trace-viewer/src/ui/networkFilters.css
+++ b/packages/trace-viewer/src/ui/networkFilters.css
@@ -39,6 +39,16 @@
text-align: center;
overflow: hidden;
text-overflow: ellipsis;
+ background: none;
+ border: none;
+ color: inherit;
+ font: inherit;
+ outline: none;
+}
+
+.network-filters-resource-type:focus-visible {
+ outline: 1px solid var(--vscode-focusBorder);
+ outline-offset: -1px;
}
.network-filters-resource-type.selected {
diff --git a/packages/trace-viewer/src/ui/networkFilters.tsx b/packages/trace-viewer/src/ui/networkFilters.tsx
index df0f0b9e73..dedb250dae 100644
--- a/packages/trace-viewer/src/ui/networkFilters.tsx
+++ b/packages/trace-viewer/src/ui/networkFilters.tsx
@@ -41,16 +41,18 @@ export const NetworkFilters = ({ filterState, onFilterStateChange }: {
/>
<div className='network-filters-resource-types' role='tablist' aria-multiselectable='true'>
- <div
+ <button
title='All'
onClick={() => onFilterStateChange({ ...filterState, resourceTypes: new Set() })}
className={`network-filters-resource-type ${filterState.resourceTypes.size === 0 ? 'selected' : ''}`}
+ role='tab'
+ aria-selected={filterState.resourceTypes.size === 0}
>
All
- </div>
+ </button>
{resourceTypes.map(resourceType => (
- <div
+ <button
key={resourceType}
title={resourceType}
onClick={event => {
@@ -67,7 +69,7 @@ export const NetworkFilters = ({ filterState, onFilterStateChange }: {
aria-selected={filterState.resourceTypes.has(resourceType)}
>
{resourceType}
- </div>
+ </button>
))}
</div>
</div>