Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(clock): reset ticks on first install to avoid realTime drift (#40198)

Dmitry Gozman2e4822eb389f
diff --git a/packages/injected/src/clock.ts b/packages/injected/src/clock.ts
index e081a2c873..69fe461163 100644
--- a/packages/injected/src/clock.ts
+++ b/packages/injected/src/clock.ts
@@ -98,7 +98,7 @@ export class ClockController {
install(time: number) {
this._replayLogOnce();
- this._innerSetTime(asWallTime(time));
+ this._innerInstall(asWallTime(time));
}
setSystemTime(time: number) {
@@ -136,6 +136,15 @@ export class ClockController {
this._now.origin = this._now.time;
}
+ private _innerInstall(time: WallTime) {
+ // On a fresh install, reset the monotonic counter so that drift
+ // accumulated by the realTime ticker before the user called install()
+ // does not leak into performance.now().
+ if (this._now.origin < 0)
+ this._now.ticks = 0 as Ticks;
+ this._innerSetTime(time);
+ }
+
private _innerSetFixedTime(time: WallTime) {
this._innerSetTime(time);
this._now.isFixedTime = true;
@@ -440,7 +449,7 @@ export class ClockController {
lastLogTime = time;
if (type === 'install') {
- this._innerSetTime(asWallTime(param!));
+ this._innerInstall(asWallTime(param!));
} else if (type === 'fastForward' || type === 'runFor') {
this._advanceNow(shiftTicks(this._now.ticks, param!));
} else if (type === 'pauseAt') {