Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(trace-viewer): validate baseURL scheme before linking (#40539)
Pavel Feldman3160ca872bf9
diff --git a/packages/isomorphic/urlMatch.ts b/packages/isomorphic/urlMatch.tsindex cdd7f0aab0..c6851d9961 100644--- a/packages/isomorphic/urlMatch.ts+++ b/packages/isomorphic/urlMatch.ts@@ -16,6 +16,14 @@import { isString } from './stringUtils';+export function isHttpUrl(url: string): boolean {+ try {+ return ['http:', 'https:'].includes(new URL(url).protocol);+ } catch {+ return false;+ }+}+// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_expressions#escapingconst escapedChars = new Set(['$', '^', '+', '.', '*', '(', ')', '|', '\\', '?', '{', '}', '[', ']']);diff --git a/packages/trace-viewer/src/ui/metadataView.tsx b/packages/trace-viewer/src/ui/metadataView.tsxindex 4fc57799f0..929a812f3f 100644--- a/packages/trace-viewer/src/ui/metadataView.tsx+++ b/packages/trace-viewer/src/ui/metadataView.tsx@@ -15,6 +15,7 @@*/import { msToString } from '@isomorphic/formatUtils';+import { isHttpUrl } from '@isomorphic/urlMatch';import * as React from 'react';import type { TraceModel } from '@isomorphic/trace/traceModel';import './callTab.css';@@ -41,7 +42,9 @@ export const MetadataView: React.FunctionComponent<{{model.options.baseURL && (<><div className='call-section' style={{ paddingTop: 2 }}>Config</div>- <div className='call-line'>baseURL:<a className='call-value string' href={model.options.baseURL} title={model.options.baseURL} target='_blank' rel='noopener noreferrer'>{model.options.baseURL}</a></div>+ <div className='call-line'>baseURL:{isHttpUrl(model.options.baseURL)+ ? <a className='call-value string' href={model.options.baseURL} title={model.options.baseURL} target='_blank' rel='noopener noreferrer'>{model.options.baseURL}</a>+ : <span className='call-value string' title={model.options.baseURL}>{model.options.baseURL}</span>}</div></>)}<div className='call-section'>Viewport</div>