Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(webview): `page.getContentQuads` should work for elements inside `<iframe>` (#41437)

Devin Rousso3387c150895f
diff --git a/packages/playwright-core/src/server/webkit/webview/wvPage.ts b/packages/playwright-core/src/server/webkit/webview/wvPage.ts
index 4c68876f60..b6f2f0cf98 100644
--- a/packages/playwright-core/src/server/webkit/webview/wvPage.ts
+++ b/packages/playwright-core/src/server/webkit/webview/wvPage.ts
@@ -888,7 +888,26 @@ export class WVPage implements PageDelegate {
}, {});
if (!result || typeof result === 'string')
return null;
- return result as types.Quad[];
+ let quads = result as types.Quad[];
+ let frame: frames.Frame | null = handle._frame;
+ while (frame?.parentFrame()) {
+ const frameElement = await this.getFrameElement(frame).catch(() => null);
+ if (!frameElement)
+ return null;
+ const offset = await frameElement.evaluateInUtility(([injected, iframe]) => {
+ const element = iframe as Element;
+ const style = injected.describeIFrameStyle(element);
+ if (style === 'error:notconnected' || style === 'transformed')
+ return null;
+ const rect = element.getBoundingClientRect();
+ return { x: rect.left + style.left, y: rect.top + style.top };
+ }, {}).finally(() => frameElement.dispose());
+ if (!offset || typeof offset === 'string')
+ return null;
+ quads = quads.map(quad => quad.map(point => ({ x: point.x + offset.x, y: point.y + offset.y })) as types.Quad);
+ frame = frame.parentFrame();
+ }
+ return quads;
}
async adoptElementHandle<T extends Node>(handle: dom.ElementHandle<T>, to: dom.FrameExecutionContext): Promise<dom.ElementHandle<T>> {
diff --git a/tests/page/elementhandle-bounding-box.spec.ts b/tests/page/elementhandle-bounding-box.spec.ts
index edd7f0fd68..23ea6ae3df 100644
--- a/tests/page/elementhandle-bounding-box.spec.ts
+++ b/tests/page/elementhandle-bounding-box.spec.ts
@@ -84,6 +84,21 @@ it('should return null for invisible elements', async ({ page, server }) => {
expect(await element.boundingBox()).toBe(null);
});
+it('should get bounding box of element inside a cross-origin iframe', async ({ page, server }) => {
+ await page.goto(server.EMPTY_PAGE);
+ await page.setContent(`
+ <div style="height:120px"></div>
+ <iframe style="border:0;margin-left:30px;width:300px;height:200px" src="${server.CROSS_PROCESS_PREFIX}/input/button.html"></iframe>
+ `);
+ const frame = page.frames()[1];
+ const button = await frame.waitForSelector('button');
+ const iframeBox = (await (await page.$('iframe')).boundingBox())!;
+ const inner = await button.evaluate(b => { const r = b.getBoundingClientRect(); return { x: r.left, y: r.top }; });
+ const box = (await button.boundingBox())!;
+ expect(Math.round(box.x)).toBe(Math.round(iframeBox.x + inner.x));
+ expect(Math.round(box.y)).toBe(Math.round(iframeBox.y + inner.y));
+});
+
it('should force a layout', async ({ page, server }) => {
await page.setViewportSize({ width: 500, height: 500 });
await page.setContent('<div style="width: 100px; height: 100px">hello</div>');