Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix: java style selector string (#36227)

Simon Knott34c295432692
diff --git a/packages/playwright-core/src/server/dom.ts b/packages/playwright-core/src/server/dom.ts
index a104b8d069..ed7cb37cef 100644
--- a/packages/playwright-core/src/server/dom.ts
+++ b/packages/playwright-core/src/server/dom.ts
@@ -86,7 +86,7 @@ export class FrameExecutionContext extends js.ExecutionContext {
const customEngines: InjectedScriptOptions['customEngines'] = [];
const selectorsRegistry = this.frame._page.browserContext.selectors();
for (const [name, { source }] of selectorsRegistry._engines)
- customEngines.push({ name, source });
+ customEngines.push({ name, source: `(${source})` });
const sdkLanguage = this.frame.attribution.playwright.options.sdkLanguage;
const options: InjectedScriptOptions = {
isUnderTest: isUnderTest(),
diff --git a/tests/page/selectors-register.spec.ts b/tests/page/selectors-register.spec.ts
index 354138a134..de2bd643d7 100644
--- a/tests/page/selectors-register.spec.ts
+++ b/tests/page/selectors-register.spec.ts
@@ -128,3 +128,17 @@ it('isVisible should be atomic', async ({ playwright, page }) => {
expect(result).toBe(true);
expect(await page.evaluate(() => document.querySelector('div').style.display)).toBe('none');
});
+
+it('should take java-style string', async ({ playwright, page }) => {
+ const createDummySelector = `{
+ query(root, selector) {
+ return root.querySelector(selector);
+ },
+ queryAll(root, selector) {
+ return root.querySelectorAll(selector);
+ }
+ }`;
+ await playwright.selectors.register('objectLiteral', createDummySelector);
+ await page.setContent(`<div>Hello</div>`);
+ await page.textContent('objectLiteral=div');
+});