Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(cli-daemon): refactor browser install and honor PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD (#39978)

Yury Semikhatsky367517dd29df
diff --git a/packages/playwright-core/src/tools/cli-daemon/program.ts b/packages/playwright-core/src/tools/cli-daemon/program.ts
index 8a7743922e..6afa3f42ab 100644
--- a/packages/playwright-core/src/tools/cli-daemon/program.ts
+++ b/packages/playwright-core/src/tools/cli-daemon/program.ts
@@ -27,6 +27,7 @@ import * as configUtils from '../mcp/config';
import { createClientInfo } from '../cli-client/registry';
import { program } from '../../utilsBundle';
import { registry as browserRegistry } from '../../server/registry/index';
+import { getAsBooleanFromENV } from '../../server/utils/env';
program.argument('[session-name]', 'name of the session to create or connect to', 'default')
.option('--headed', 'run in headed mode (non-headless)')
@@ -103,17 +104,16 @@ async function initWorkspace(initSkills: string | undefined) {
}
async function ensureConfiguredBrowserInstalled() {
+ if (getAsBooleanFromENV('PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD'))
+ return;
if (fs.existsSync(defaultConfigFile()) || fs.existsSync(globalConfigFile())) {
// Config exists, ensure configured browser is installed
const clientInfo = createClientInfo();
const config = await configUtils.resolveCLIConfigForCLI(clientInfo.daemonProfilesDir, 'default', {});
const browserName = config.browser.browserName;
const channel = config.browser.launchOptions.channel;
- if (!channel || channel.startsWith('chromium')) {
- const executable = browserRegistry.findExecutable(channel ?? browserName);
- if (executable && !fs.existsSync(executable.executablePath()!))
- await browserRegistry.install([executable]);
- }
+ if (!channel || channel.startsWith('chromium'))
+ await resolveAndInstall(channel ?? browserName);
} else {
const channel = await findOrInstallDefaultBrowser();
if (channel !== 'chrome')
@@ -127,15 +127,19 @@ async function findOrInstallDefaultBrowser() {
const executable = browserRegistry.findExecutable(channel);
if (!executable?.executablePath())
continue;
+ await resolveAndInstall('ffmpeg');
console.log(`✅ Found ${channel}, will use it as the default browser.`);
return channel;
}
- const chromiumExecutable = browserRegistry.findExecutable('chromium');
- if (!fs.existsSync(chromiumExecutable?.executablePath()!))
- await browserRegistry.install([chromiumExecutable]);
+ await resolveAndInstall('chromium');
return 'chromium';
}
+async function resolveAndInstall(nameOrChannel: string) {
+ const executables = browserRegistry.resolveBrowsers([nameOrChannel], { shell: 'no' });
+ await browserRegistry.install(executables);
+}
+
async function createDefaultConfig(channel: string) {
const config = {
browser: {