Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(trace-viewer): improve aria tab roles (#38016)
Adam Gastineau388bc6a090b2
diff --git a/packages/trace-viewer/src/ui/networkFilters.tsx b/packages/trace-viewer/src/ui/networkFilters.tsxindex 5ce9d57aa2..7d38e83195 100644--- a/packages/trace-viewer/src/ui/networkFilters.tsx+++ b/packages/trace-viewer/src/ui/networkFilters.tsx@@ -40,7 +40,7 @@ export const NetworkFilters = ({ filterState, onFilterStateChange }: {onChange={e => onFilterStateChange({ ...filterState, searchValue: e.target.value })}/>- <div className='network-filters-resource-types'>+ <div className='network-filters-resource-types' role='tablist' aria-multiselectable='true'><divtitle='All'onClick={() => onFilterStateChange({ ...filterState, resourceTypes: new Set() })}@@ -63,6 +63,8 @@ export const NetworkFilters = ({ filterState, onFilterStateChange }: {onFilterStateChange({ ...filterState, resourceTypes: newType });}}className={`network-filters-resource-type ${filterState.resourceTypes.has(resourceType) ? 'selected' : ''}`}+ role='tab'+ aria-selected={filterState.resourceTypes.has(resourceType)}>{resourceType}</div>diff --git a/packages/trace-viewer/src/ui/snapshotTab.tsx b/packages/trace-viewer/src/ui/snapshotTab.tsxindex 82c68078cb..382e459829 100644--- a/packages/trace-viewer/src/ui/snapshotTab.tsx+++ b/packages/trace-viewer/src/ui/snapshotTab.tsx@@ -65,15 +65,17 @@ export const SnapshotTabsView: React.FunctionComponent<{return <div className='snapshot-tab vbox'><Toolbar><ToolbarButton className='pick-locator' title='Pick locator' icon='target' toggled={isInspecting} onClick={() => setIsInspecting(!isInspecting)} />- {['action', 'before', 'after'].map(tab => {- return <TabbedPaneTab- key={tab}- id={tab}- title={renderTitle(tab)}- selected={snapshotTab === tab}- onSelect={() => setSnapshotTab(tab as 'action' | 'before' | 'after')}- ></TabbedPaneTab>;- })}+ <div className='hbox' style={{ height: '100%' }} role='tablist'>+ {(['action', 'before', 'after'] as const).map(tab => {+ return <TabbedPaneTab+ key={tab}+ id={tab}+ title={renderTitle(tab)}+ selected={snapshotTab === tab}+ onSelect={() => setSnapshotTab(tab)}+ />;+ })}+ </div><div style={{ flex: 'auto' }}></div><ToolbarButton icon='link-external' title='Open snapshot in a new tab' disabled={!snapshotUrls?.popoutUrl} onClick={() => {const win = window.open(snapshotUrls?.popoutUrl || '', '_blank');diff --git a/packages/web/src/components/tabbedPane.tsx b/packages/web/src/components/tabbedPane.tsxindex 95b0fa540c..84cbc9f3b6 100644--- a/packages/web/src/components/tabbedPane.tsx+++ b/packages/web/src/components/tabbedPane.tsx@@ -106,7 +106,8 @@ export const TabbedPaneTab: React.FunctionComponent<{onClick={() => onSelect?.(id)}role='tab'title={title}- aria-controls={ariaControls}>+ aria-controls={ariaControls}+ aria-selected={selected}><div className='tabbed-pane-tab-label'>{title}</div>{!!count && <div className='tabbed-pane-tab-counter'>{count}</div>}{!!errorCount && <div className='tabbed-pane-tab-counter error'>{errorCount}</div>}