Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(bidi): add support for the local-network-access permission (#42054)

Holger Benl399c655485e4
diff --git a/packages/playwright-core/src/server/bidi/bidiBrowser.ts b/packages/playwright-core/src/server/bidi/bidiBrowser.ts
index 95546d70fe..c4f2280baf 100644
--- a/packages/playwright-core/src/server/bidi/bidiBrowser.ts
+++ b/packages/playwright-core/src/server/bidi/bidiBrowser.ts
@@ -331,8 +331,11 @@ export class BidiBrowserContext extends BrowserContext {
async doGrantPermissions(origin: string, permissions: string[]) {
if (origin === 'null')
return;
+ const protocolPermissions = permissions.flatMap(
+ permission => permission === 'local-network-access' ? ['local-network', 'loopback-network'] : permission
+ );
const currentPermissions = this._originToPermissions.get(origin) || [];
- const toGrant = permissions.filter(permission => !currentPermissions.includes(permission));
+ const toGrant = protocolPermissions.filter(permission => !currentPermissions.includes(permission));
this._originToPermissions.set(origin, [...currentPermissions, ...toGrant]);
if (origin === '*') {
await Promise.all(this._bidiPages().flatMap(page =>
diff --git a/tests/bidi/expectations/moz-firefox-nightly-library.txt b/tests/bidi/expectations/moz-firefox-nightly-library.txt
index 94bf37ef56..ff9869d611 100644
--- a/tests/bidi/expectations/moz-firefox-nightly-library.txt
+++ b/tests/bidi/expectations/moz-firefox-nightly-library.txt
@@ -155,7 +155,6 @@ library/page-event-crash.spec.ts › should cancel navigation when page crashes
library/page-event-crash.spec.ts › should cancel waitForEvent when page crashes [timeout]
library/page-event-crash.spec.ts › should emit crash event when page crashes [timeout]
library/page-event-crash.spec.ts › should throw on any action after page crashes [timeout]
-library/permissions.spec.ts › local network request is allowed from public origin [timeout]
library/permissions.spec.ts › permissions › should deny permission when not listed [fail]
library/permissions.spec.ts › permissions › should fail when bad permission is given [fail]
library/permissions.spec.ts › permissions › should isolate permissions between browser contexts [fail]