Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(bidi): remove request body headers from overrides for redirected requests (#39106)
Holger Benl3ad519c7fba5
diff --git a/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts b/packages/playwright-core/src/server/bidi/bidiNetworkManager.tsindex 2a646c673b..216ab08376 100644--- a/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts+++ b/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts@@ -25,6 +25,7 @@ import type { Page } from '../page';import type * as types from '../types';import type { BidiSession } from './bidiConnection';+const REQUEST_BODY_HEADERS = new Set(['content-encoding', 'content-language', 'content-location', 'content-type']);export class BidiNetworkManager {private readonly _session: BidiSession;@@ -72,6 +73,10 @@ export class BidiNetworkManager {if (redirectedFrom._originalRequestRoute?._alreadyContinuedHeaders) {const originalHeaders = fromBidiHeaders(param.request.headers);headersOverride = network.applyHeadersOverrides(originalHeaders, redirectedFrom._originalRequestRoute._alreadyContinuedHeaders);+ // If the redirect turned a POST into a GET request, remove the request body headers,+ // corresponding to step 12 of https://fetch.spec.whatwg.org/#http-redirect-fetch.+ if (redirectedFrom.request.method() === 'POST' && param.request.method === 'GET')+ headersOverride = headersOverride.filter(({ name }) => !REQUEST_BODY_HEADERS.has(name.toLowerCase()));params = toBidiRequestHeaders(headersOverride);}diff --git a/tests/bidi/expectations/moz-firefox-nightly-page.txt b/tests/bidi/expectations/moz-firefox-nightly-page.txtindex 25bc463f54..366c3de52c 100644--- a/tests/bidi/expectations/moz-firefox-nightly-page.txt+++ b/tests/bidi/expectations/moz-firefox-nightly-page.txt@@ -133,7 +133,6 @@ page/page-network-response.spec.ts › should report all headers [fail]page/page-network-response.spec.ts › should report if request was fromServiceWorker [fail]page/page-network-response.spec.ts › should report multiple set-cookie headers [fail]page/page-network-response.spec.ts › should wait until response completes [fail]-page/page-request-continue.spec.ts › continue should drop content-length on redirects [timeout]page/page-request-continue.spec.ts › should not throw if request was cancelled by the page [timeout]page/page-request-fulfill.spec.ts › should fulfill with gzip and readback [timeout]page/page-request-fulfill.spec.ts › should not throw if request was cancelled by the page [timeout]