Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(android): do not report all artifactsDirs as errors (#35530)

Max Schmitt3b70f95b17a6
diff --git a/packages/playwright-core/src/server/android/android.ts b/packages/playwright-core/src/server/android/android.ts
index f85beb6e73..1d03437387 100644
--- a/packages/playwright-core/src/server/android/android.ts
+++ b/packages/playwright-core/src/server/android/android.ts
@@ -323,7 +323,7 @@ export class AndroidDevice extends SdkObject {
const artifactsDir = await fs.promises.mkdtemp(ARTIFACTS_FOLDER);
const cleanupArtifactsDir = async () => {
- const errors = await removeFolders([artifactsDir]);
+ const errors = (await removeFolders([artifactsDir])).filter(Boolean);
for (let i = 0; i < (errors || []).length; ++i)
debug('pw:android')(`exception while removing ${artifactsDir}: ${errors[i]}`);
};
diff --git a/packages/playwright-core/src/server/utils/fileUtils.ts b/packages/playwright-core/src/server/utils/fileUtils.ts
index 4179df79fe..3eab2c0366 100644
--- a/packages/playwright-core/src/server/utils/fileUtils.ts
+++ b/packages/playwright-core/src/server/utils/fileUtils.ts
@@ -29,7 +29,7 @@ export async function mkdirIfNeeded(filePath: string) {
await fs.promises.mkdir(path.dirname(filePath), { recursive: true }).catch(() => {});
}
-export async function removeFolders(dirs: string[]): Promise<Error[]> {
+export async function removeFolders(dirs: string[]): Promise<(Error| undefined)[]> {
return await Promise.all(dirs.map((dir: string) =>
fs.promises.rm(dir, { recursive: true, force: true, maxRetries: 10 }).catch(e => e)
));