Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(bidi): ignore exception when trying to get a frame's name (#39657)

Holger Benl3bb46d49b309
diff --git a/packages/playwright-core/src/server/bidi/bidiBrowser.ts b/packages/playwright-core/src/server/bidi/bidiBrowser.ts
index e7ac1fc318..9a4ac5b7cb 100644
--- a/packages/playwright-core/src/server/bidi/bidiBrowser.ts
+++ b/packages/playwright-core/src/server/bidi/bidiBrowser.ts
@@ -143,7 +143,7 @@ export class BidiBrowser extends Browser {
page._getFrameNode(frame).then(node => {
const attributes = node?.value?.attributes;
frame._name = attributes?.name ?? attributes?.id ?? '';
- });
+ }, () => {});
return;
}
return;
diff --git a/tests/bidi/expectations/moz-firefox-nightly-page.txt b/tests/bidi/expectations/moz-firefox-nightly-page.txt
index 12038eb0e8..b0237ad336 100644
--- a/tests/bidi/expectations/moz-firefox-nightly-page.txt
+++ b/tests/bidi/expectations/moz-firefox-nightly-page.txt
@@ -15,7 +15,6 @@ page/frame-evaluate.spec.ts › should allow cross-frame element handles [fail]
page/frame-evaluate.spec.ts › should not allow cross-frame element handles when frames do not script each other [fail]
page/frame-evaluate.spec.ts › should dispose context on cross-origin navigation [fail]
page/frame-evaluate.spec.ts › should dispose context on navigation [fail]
-page/frame-goto.spec.ts › should continue after client redirect [flaky]
page/frame-hierarchy.spec.ts › should support framesets [fail]
page/interception.spec.ts › should disable memory cache when intercepting [timeout]
page/interception.spec.ts › should intercept worker requests when enabled after worker creation [timeout]
@@ -92,7 +91,6 @@ page/page-emulate-media.spec.ts › should emulate type @smoke [fail]
page/page-emulate-media.spec.ts › should keep reduced motion and color emulation after reload [fail]
page/page-emulate-media.spec.ts › should work during navigation [fail]
page/page-event-console.spec.ts › should have location for console API calls [fail]
-page/page-event-console.spec.ts › should not throw when there are console messages in detached iframes [fail]
page/page-event-console.spec.ts › should trigger correct Log [timeout]
page/page-event-console.spec.ts › should work @smoke [flaky]
page/page-event-console.spec.ts › should work for different console API calls [fail]
@@ -106,7 +104,6 @@ page/page-fill.spec.ts › should throw nice error without injected script stack
page/page-goto.spec.ts › should override referrer-policy [fail]
page/page-goto.spec.ts › should send referer [fail]
page/page-goto.spec.ts › should send referer of cross-origin URL [fail]
-page/page-goto.spec.ts › should work with subframes return 204 with domcontentloaded [flaky]
page/page-history.spec.ts › goBack/goForward should work with bfcache-able pages [timeout]
page/page-history.spec.ts › page.goBack should work for file urls [timeout]
page/page-history.spec.ts › regression test for issue 20791 [flaky]