Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(network): do not cache response body on the server (#42847)
Yury Semikhatsky3bbcbca70216
diff --git a/packages/playwright-core/src/server/network.ts b/packages/playwright-core/src/server/network.tsindex 8de38cf756..d25f342645 100644--- a/packages/playwright-core/src/server/network.ts+++ b/packages/playwright-core/src/server/network.ts@@ -513,7 +513,6 @@ export type SecurityDetails = {export class Response extends SdkObject {private _request: Request;- private _contentPromise: Promise<Buffer> | null = null;private _finishedPromise = new ManualPromise<void>();private _status: number;private _statusText: string;@@ -644,25 +643,21 @@ export class Response extends SdkObject {return await this._rawResponseHeadersPromise;}- internalBody(): Promise<Buffer> {- if (!this._contentPromise) {- this._contentPromise = this._finishedPromise.then(async () => {- if (this._status >= 300 && this._status <= 399)- throw new Error('Response body is unavailable for redirect responses');- if (this._request._responseBodyOverride) {- const { body, isBase64 } = this._request._responseBodyOverride;- return Buffer.from(body, isBase64 ? 'base64' : 'utf-8');- }- try {- return await this._getResponseBodyCallback();- } catch (e) {- if (isProtocolError(e) && e.type === 'error')- rewriteErrorMessage(e, e.message + '\nResponse body is not available for a response that was navigated away from. Read response.body() before triggering any navigation.');- throw e;- }- });+ async internalBody(): Promise<Buffer> {+ await this._finishedPromise;+ if (this._status >= 300 && this._status <= 399)+ throw new Error('Response body is unavailable for redirect responses');+ if (this._request._responseBodyOverride) {+ const { body, isBase64 } = this._request._responseBodyOverride;+ return Buffer.from(body, isBase64 ? 'base64' : 'utf-8');+ }+ try {+ return await this._getResponseBodyCallback();+ } catch (e) {+ if (isProtocolError(e) && e.type === 'error')+ rewriteErrorMessage(e, e.message + '\nResponse body is not available for a response that was navigated away from. Read response.body() before triggering any navigation.');+ throw e;}- return this._contentPromise;}request(): Request {diff --git a/tests/page/page-network-response.spec.ts b/tests/page/page-network-response.spec.tsindex 9ec3e8eb61..d1bbf7593c 100644--- a/tests/page/page-network-response.spec.ts+++ b/tests/page/page-network-response.spec.ts@@ -515,9 +515,8 @@ it('Response.formData() should parse multipart/form-data in page context', asyncexpect(result.fileContent).toBe('hello');});-it('should give a readable error when response.body() races with navigation', async ({ page, server, browserName, trace }) => {+it('should give a readable error when response.body() races with navigation', async ({ page, server, browserName }) => {it.skip(browserName === 'firefox', 'Firefox keeps the response body available after navigating away, so it never throws');- it.skip(trace === 'on', 'Tracing fetches response bodies eagerly, so the body is already cached before navigation');it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41512' });const [response] = await Promise.all([page.waitForResponse(server.PREFIX + '/title.html'),