Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: fix electron installation test (#38305)

Yury Semikhatsky3bf5c9294756
diff --git a/packages/playwright-core/src/server/electron/electron.ts b/packages/playwright-core/src/server/electron/electron.ts
index 8d54cbd39b..c84076b624 100644
--- a/packages/playwright-core/src/server/electron/electron.ts
+++ b/packages/playwright-core/src/server/electron/electron.ts
@@ -198,7 +198,7 @@ export class Electron extends SdkObject {
// On Windows, we need to quote the executable path and arguments due to shell: true.
// We allso pass the arguments as a single string due to DEP0190,
// see https://github.com/microsoft/playwright/issues/38278.
- command = [command, ...electronArguments].map(arg => `"${escapeWinCmdArg(arg)}"`).join(' ');
+ command = [command, ...electronArguments].map(arg => `"${escapeDoubleQuotes(arg)}"`).join(' ');
electronArguments = [];
}
@@ -317,6 +317,6 @@ async function waitForLine(progress: Progress, process: childProcess.ChildProces
}
}
-function escapeWinCmdArg(str: string): string {
- return str.replace(/"/g, '\\"').replace(/%([^%].)/g, '%^$1');
+function escapeDoubleQuotes(str: string): string {
+ return str.replace(/"/g, '\\"');
}
diff --git a/tests/electron/electron-app.spec.ts b/tests/electron/electron-app.spec.ts
index ea4d6f4b07..a4393b53d1 100644
--- a/tests/electron/electron-app.spec.ts
+++ b/tests/electron/electron-app.spec.ts
@@ -130,10 +130,10 @@ test('should script application', async ({ electronApp }) => {
});
test('should preserve args', async ({ launchElectronApp, isMac }) => {
- const electronApp = await launchElectronApp('electron-app-args.js', ['foo', 'bar', '%PATH%', '& <>^|\\"']);
+ const electronApp = await launchElectronApp('electron-app-args.js', ['foo', 'bar', '& <>^|\\"']);
const argv = await electronApp.evaluate(async () => globalThis.argv);
const electronPath = isMac ? path.join('dist', 'Electron.app') : path.join('dist', 'electron');
- expect(argv).toEqual([expect.stringContaining(electronPath), expect.stringContaining(path.join('electron', 'electron-app-args.js')), 'foo', 'bar', '%^PATH%', '& <>^|\\"']);
+ expect(argv).toEqual([expect.stringContaining(electronPath), expect.stringContaining(path.join('electron', 'electron-app-args.js')), 'foo', 'bar', '& <>^|\\"']);
});
test('should return windows', async ({ electronApp, newWindow }) => {