Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(glob): do not treat custom schema as special (#37851)
Yury Semikhatsky3f67e719aa20
diff --git a/packages/playwright-core/src/utils/isomorphic/urlMatch.ts b/packages/playwright-core/src/utils/isomorphic/urlMatch.tsindex b526ca732e..e4b0cc6edc 100644--- a/packages/playwright-core/src/utils/isomorphic/urlMatch.ts+++ b/packages/playwright-core/src/utils/isomorphic/urlMatch.ts@@ -132,8 +132,13 @@ function resolveGlobBase(baseURL: string | undefined, match: string): string {return token;// Handle special case of http*://, note that the new schema has to be// a web schema so that slashes are properly inserted after domain.- if (index === 0 && token.endsWith(':'))- return mapToken(token, 'http:');+ if (index === 0 && token.endsWith(':')) {+ // Replace any pattern with http:+ if (token.indexOf('*') !== -1 || token.indexOf('{') !== -1)+ return mapToken(token, 'http:');+ // Preserve explicit schema as is as it may affect trailing slashes after domain.+ return token;+ }const questionIndex = token.indexOf('?');if (questionIndex === -1)return mapToken(token, `$_${index}_$`);diff --git a/tests/page/interception.spec.ts b/tests/page/interception.spec.tsindex b8653f9ef3..a0ef182de1 100644--- a/tests/page/interception.spec.ts+++ b/tests/page/interception.spec.ts@@ -127,6 +127,12 @@ it('should work with glob', async () => {expect(urlMatches(undefined, 'https://localhost:3000/?a=b', '**?a=b')).toBeTruthy();expect(urlMatches(undefined, 'https://localhost:3000/?a=b', '**=b')).toBeTruthy();+ // Custom schema.+ expect(urlMatches(undefined, 'my.custom.protocol://foo', 'my.custom.protocol://**')).toBeTruthy();+ expect(urlMatches(undefined, 'my.p://foo', 'my.{p,y}://**')).toBeFalsy();+ expect(urlMatches(undefined, 'my.p://foo/', 'my.{p,y}://**')).toBeTruthy();+ expect(urlMatches(undefined, 'file:///foo/', 'f*e://**')).toBeTruthy();+// This is not supported, we treat ? as a query separator.expect(globToRegex('http://localhost:8080/?imple/path.js').test('http://localhost:8080/Simple/path.js')).toBeFalsy();expect(urlMatches(undefined, 'http://playwright.dev/', 'http://playwright.?ev')).toBeFalsy();