Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(mcp): never use old headless (#39391)
Pavel Feldman408bbc2ab604
diff --git a/packages/playwright/src/mcp/browser/config.ts b/packages/playwright/src/mcp/browser/config.tsindex 09be56750f..374e9d4597 100644--- a/packages/playwright/src/mcp/browser/config.ts+++ b/packages/playwright/src/mcp/browser/config.ts@@ -158,7 +158,7 @@ export async function resolveCLIConfig(cliOptions: CLIOptions): Promise<FullConfexport async function validateConfig(config: FullConfig): Promise<void> {if (config.browser.browserName === 'chromium' && config.browser.launchOptions.chromiumSandbox === undefined) {if (process.platform === 'linux')- config.browser.launchOptions.chromiumSandbox = config.browser.launchOptions.channel !== 'chromium';+ config.browser.launchOptions.chromiumSandbox = config.browser.launchOptions.channel !== 'chromium' && config.browser.launchOptions.channel !== 'chrome-for-testing';elseconfig.browser.launchOptions.chromiumSandbox = true;}@@ -198,7 +198,6 @@ export function configFromCLIOptions(cliOptions: CLIOptions): Config & { configFcase 'chrome-beta':case 'chrome-canary':case 'chrome-dev':- case 'chromium':case 'msedge':case 'msedge-beta':case 'msedge-canary':@@ -206,6 +205,11 @@ export function configFromCLIOptions(cliOptions: CLIOptions): Config & { configFbrowserName = 'chromium';channel = cliOptions.browser;break;+ case 'chromium':+ // Never use old headless.+ browserName = 'chromium';+ channel = 'chrome-for-testing';+ break;case 'firefox':browserName = 'firefox';break;diff --git a/tests/mcp/cli-isolated.spec.ts b/tests/mcp/cli-isolated.spec.tsindex ff9c6c278f..aedc266e28 100644--- a/tests/mcp/cli-isolated.spec.ts+++ b/tests/mcp/cli-isolated.spec.ts@@ -18,10 +18,10 @@ import fs from 'fs';import path from 'path';import { test, expect, findDefaultSession, daemonFolder } from './cli-fixtures';-test('should not save user data by default (in-memory mode)', async ({ cli, server, mcpBrowser }, testInfo) => {+test('should not save user data by default (in-memory mode)', async ({ cli, server, mcpBrowserNormalized }, testInfo) => {await cli('open', server.HELLO_WORLD);const sessionOptions = await findDefaultSession();- const dataDir = path.resolve(await daemonFolder(), 'ud-default-' + mcpBrowser);+ const dataDir = path.resolve(await daemonFolder(), 'ud-default-' + mcpBrowserNormalized);expect(fs.existsSync(dataDir)).toBe(false);expect(sessionOptions).toEqual({name: 'default',@@ -38,15 +38,15 @@ test('should not save user data by default (in-memory mode)', async ({ cli, servexpect(listOutput).toContain(`### Browsers- default:- status: open- - browser-type: ${mcpBrowser}+ - browser-type: ${mcpBrowserNormalized}- user-data-dir: <in-memory>- headed: false`);});-test('should save user data with --persistent flag', async ({ cli, server, mcpBrowser }, testInfo) => {+test('should save user data with --persistent flag', async ({ cli, server, mcpBrowserNormalized }, testInfo) => {await cli('open', server.HELLO_WORLD, '--persistent');const sessionOptions = await findDefaultSession();- const dataDir = path.resolve(await daemonFolder(), 'ud-default-' + mcpBrowser);+ const dataDir = path.resolve(await daemonFolder(), 'ud-default-' + mcpBrowserNormalized);expect(fs.existsSync(dataDir)).toBe(true);expect(sessionOptions).toEqual({name: 'default',diff --git a/tests/mcp/cli-session.spec.ts b/tests/mcp/cli-session.spec.tsindex 4c0e72498c..bf80a76787 100644--- a/tests/mcp/cli-session.spec.ts+++ b/tests/mcp/cli-session.spec.ts@@ -79,10 +79,10 @@ test('close-all', async ({ cli, server }) => {expect(listAfter).not.toContain('session1');});-test('delete-data', async ({ cli, server, mcpBrowser }, testInfo) => {+test('delete-data', async ({ cli, server, mcpBrowserNormalized }) => {await cli('open', server.HELLO_WORLD, '--persistent');- const dataDir = path.resolve(await daemonFolder(), 'ud-default-' + mcpBrowser);+ const dataDir = path.resolve(await daemonFolder(), 'ud-default-' + mcpBrowserNormalized);expect(fs.existsSync(dataDir)).toBe(true);const { output } = await cli('delete-data');@@ -91,10 +91,10 @@ test('delete-data', async ({ cli, server, mcpBrowser }, testInfo) => {expect(fs.existsSync(dataDir)).toBe(false);});-test('delete-data named session', async ({ cli, server, mcpBrowser }, testInfo) => {+test('delete-data named session', async ({ cli, server, mcpBrowserNormalized }) => {await cli('-s', 'mysession', 'open', server.HELLO_WORLD, '--persistent');- const dataDir = path.resolve(await daemonFolder(), 'ud-mysession-' + mcpBrowser);+ const dataDir = path.resolve(await daemonFolder(), 'ud-mysession-' + mcpBrowserNormalized);expect(fs.existsSync(dataDir)).toBe(true);const { output } = await cli('-s', 'mysession', 'delete-data');diff --git a/tests/mcp/fixtures.ts b/tests/mcp/fixtures.tsindex 33cb3b91ae..4da354d557 100644--- a/tests/mcp/fixtures.ts+++ b/tests/mcp/fixtures.ts@@ -40,6 +40,7 @@ export { parseResponse };export type TestOptions = {mcpArgs: string[] | undefined;mcpBrowser: string | undefined;+ mcpBrowserNormalized: string | undefined;mcpCaps: string[] | undefined;mcpServerType: 'mcp' | 'test-mcp';};@@ -201,6 +202,11 @@ export const test = serverTest.extend<TestFixtures & TestOptions, WorkerFixturesmcpBrowser: ['chrome', { option: true }],+ mcpBrowserNormalized: async ({ mcpBrowser }, use) => {+ const normalized = mcpBrowser?.replace(/chromium/, 'chrome-for-testing');+ await use(normalized);+ },+mcpServerType: ['mcp', { option: true }],});diff --git a/tests/mcp/profile-lock.spec.ts b/tests/mcp/profile-lock.spec.tsindex 3d902e4551..98377435fb 100644--- a/tests/mcp/profile-lock.spec.ts+++ b/tests/mcp/profile-lock.spec.ts@@ -29,7 +29,7 @@ test('isProfileLocked detects a real browser holding the profile', async ({ mcpBtest.skip(!['chromium', 'chrome', 'msedge'].includes(mcpBrowser!), 'Chromium-only');const userDataDir = testInfo.outputPath('user-data-dir');const context = await chromium.launchPersistentContext(userDataDir, {- channel: mcpBrowser === 'chromium' ? undefined : mcpBrowser,+ channel: mcpBrowser === 'chromium' ? 'chrome-for-testing' : mcpBrowser,headless: true,});try {@@ -43,7 +43,7 @@ test('isProfileLocked returns false after browser closes', async ({ mcpBrowser }test.skip(!['chromium', 'chrome', 'msedge'].includes(mcpBrowser!), 'Chromium-only');const userDataDir = testInfo.outputPath('user-data-dir');const context = await chromium.launchPersistentContext(userDataDir, {- channel: mcpBrowser === 'chromium' ? undefined : mcpBrowser,+ channel: mcpBrowser === 'chromium' ? 'chrome-for-testing' : mcpBrowser,headless: true,});await context.close();