Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

devops: preserve output in watch mode (#35916)

Yury Semikhatsky4166fd2bbd1e
diff --git a/utils/build/build.js b/utils/build/build.js
index 28ab8975dd..9fd4946457 100644
--- a/utils/build/build.js
+++ b/utils/build/build.js
@@ -324,8 +324,8 @@ class EsbuildStep extends Step {
try {
await this._context?.rebuild();
} catch (e) {
-
- console.error('Rebuild failed:', e);
+ // Ignore. Esbuild inherits stderr and already logs nicely formatted errors
+ // before throwing.
}
this._rebuilding = false;
@@ -409,7 +409,8 @@ if (watchMode) {
'vite', '--config', 'vite.sw.config.ts',
'build', '--watch', '--minify=false',
'--outDir', path.join(__dirname, '..', '..', 'packages', 'playwright-core', 'lib', 'vite', 'traceViewer'),
- '--emptyOutDir=false'
+ '--emptyOutDir=false',
+ '--clearScreen=false',
],
shell: true,
cwd: path.join(__dirname, '..', '..', 'packages', 'trace-viewer'),
@@ -426,6 +427,7 @@ for (const webPackage of ['html-reporter', 'recorder', 'trace-viewer']) {
'build',
...(watchMode ? ['--watch', '--minify=false'] : []),
...(withSourceMaps ? ['--sourcemap=inline'] : []),
+ '--clearScreen=false',
],
shell: true,
cwd: path.join(__dirname, '..', '..', 'packages', webPackage),
@@ -437,21 +439,21 @@ for (const webPackage of ['html-reporter', 'recorder', 'trace-viewer']) {
if (watchMode) {
steps.push(new ProgramStep({
command: 'npx',
- args: ['vite', '--port', '44223', '--base', '/trace/'],
+ args: ['vite', '--port', '44223', '--base', '/trace/', '--clearScreen=false'],
shell: true,
cwd: path.join(__dirname, '..', '..', 'packages', 'trace-viewer'),
concurrent: true,
}));
steps.push(new ProgramStep({
command: 'npx',
- args: ['vite', '--port', '44224'],
+ args: ['vite', '--port', '44224', '--clearScreen=false'],
shell: true,
cwd: path.join(__dirname, '..', '..', 'packages', 'html-reporter'),
concurrent: true,
}));
steps.push(new ProgramStep({
command: 'npx',
- args: ['vite', '--port', '44225'],
+ args: ['vite', '--port', '44225', '--clearScreen=false'],
shell: true,
cwd: path.join(__dirname, '..', '..', 'packages', 'recorder'),
concurrent: true,
@@ -535,14 +537,14 @@ if (watchMode) {
// Run TypeScript for type checking.
steps.push(new ProgramStep({
command: 'npx',
- args: ['tsc', ...(watchMode ? ['-w'] : []), '-p', quotePath(filePath('.'))],
+ args: ['tsc', ...(watchMode ? ['-w'] : []), '--preserveWatchOutput', '-p', quotePath(filePath('.'))],
shell: true,
concurrent: true,
}));
for (const webPackage of ['html-reporter', 'recorder', 'trace-viewer']) {
steps.push(new ProgramStep({
command: 'npx',
- args: ['tsc', ...(watchMode ? ['-w'] : []), '-p', quotePath(filePath(`packages/${webPackage}`))],
+ args: ['tsc', ...(watchMode ? ['-w'] : []), '--preserveWatchOutput', '-p', quotePath(filePath(`packages/${webPackage}`))],
shell: true,
concurrent: true,
}));