Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(mcp): wait for next pause or context closure in browser_resume (#41293)
Sebastien Tardif41a39306ccef
diff --git a/packages/playwright-core/src/tools/backend/devtools.ts b/packages/playwright-core/src/tools/backend/devtools.tsindex 300793b84d..56fe53258e 100644--- a/packages/playwright-core/src/tools/backend/devtools.ts+++ b/packages/playwright-core/src/tools/backend/devtools.ts@@ -48,6 +48,10 @@ const resume = defineTool({}};browserContext.debugger.on('pausedstatechanged', listener);+ browserContext.once('close', () => {+ browserContext.debugger.off('pausedstatechanged', listener);+ resolve();+ });});if (params.location) {diff --git a/tests/mcp/devtools.spec.ts b/tests/mcp/devtools.spec.tsindex dc665f6d51..c7350f376f 100644--- a/tests/mcp/devtools.spec.ts+++ b/tests/mcp/devtools.spec.ts@@ -93,6 +93,29 @@ test('browser_hide_highlight', async ({ boundBrowser, startClient }) => {await expect(page.locator('x-pw-highlight')).toHaveCount(0);});+test('browser_resume completes when context closes', async ({ boundBrowser, startClient }) => {+ const page = await boundBrowser.newPage();+ await page.setContent(`<button>Submit</button>`);+ const context = boundBrowser.contexts()[0];++ // Pause the debugger before the next action.+ await context.debugger.requestPause();+ const clickPromise = page.click('button');+ await new Promise<void>(resolve => context.debugger.once('pausedstatechanged', resolve));+ expect(context.debugger.pausedDetails()).toBeTruthy();++ // browser_resume without step or location resumes execution and+ // waits for either the next pause or context close. Closing the+ // context after resume simulates a test finishing with no further+ // breakpoints. Before the fix, this would hang indefinitely.+ const { client } = await startClient({ args: [`--endpoint=default`] });+ const resumePromise = client.callTool({ name: 'browser_resume' });++ await clickPromise;+ await context.close();+ await resumePromise;+});+test('browser_hide_highlight all', async ({ boundBrowser, startClient }) => {const page = await boundBrowser.newPage();await page.setContent(`<button>Submit</button><a href="#">Go</a>`);