Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(expect): account for undefined matcherResult (#38379)

Dmitry Gozman44ad7d44e83c
diff --git a/packages/playwright/src/matchers/matcherHint.ts b/packages/playwright/src/matchers/matcherHint.ts
index 6fc0e10eb6..7c0b809b35 100644
--- a/packages/playwright/src/matchers/matcherHint.ts
+++ b/packages/playwright/src/matchers/matcherHint.ts
@@ -109,7 +109,7 @@ export class ExpectError extends Error {
}
export function isJestError(e: unknown): e is JestError {
- return e instanceof Error && 'matcherResult' in e;
+ return e instanceof Error && 'matcherResult' in e && !!e.matcherResult;
}
export const callLogText = (log: string[] | undefined) => {
diff --git a/tests/playwright-test/expect.spec.ts b/tests/playwright-test/expect.spec.ts
index 67ec3bac0e..ef89d4b1bb 100644
--- a/tests/playwright-test/expect.spec.ts
+++ b/tests/playwright-test/expect.spec.ts
@@ -1319,3 +1319,19 @@ test('should support arrayOf', async ({ runInlineTest }) => {
expect(result.failed).toBe(1);
expect(result.output).toContain('ArrayOf Any<Number>');
});
+
+test('should account for undefined matcherResult', async ({ runInlineTest }) => {
+ const result = await runInlineTest({
+ 'example.spec.ts': `
+ import { test, expect } from '@playwright/test';
+ test('fails', async () => {
+ await expect(new Promise(f => setTimeout(f, 500))).rejects.toThrow();
+ });
+ `
+ });
+ expect(result.exitCode).toBe(1);
+ expect(result.passed).toBe(0);
+ expect(result.output).toContain('Error: expect(received).rejects.toThrow()');
+ expect(result.output).toContain('Received promise resolved instead of rejected');
+ expect(result.output).toContain('Resolved to value: undefined');
+});