Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(server): await _onDisconnect in PlaywrightConnection.close (#40183)
Dmitry Gozman4b450016d24e
diff --git a/packages/playwright-core/src/remote/playwrightConnection.ts b/packages/playwright-core/src/remote/playwrightConnection.tsindex dbf41ceaa2..5bc2e69192 100644--- a/packages/playwright-core/src/remote/playwrightConnection.ts+++ b/packages/playwright-core/src/remote/playwrightConnection.ts@@ -37,7 +37,7 @@ export class PlaywrightConnection {private _dispatcherConnection: DispatcherConnection;private _cleanups: (() => Promise<void>)[] = [];private _id: string;- private _disconnected = false;+ private _onDisconnectPromise: Promise<void> | undefined;private _root: DispatcherScope;private _profileName: string;@@ -110,10 +110,13 @@ export class PlaywrightConnection {});}- private async _onDisconnect(error?: Error) {- if (this._disconnected)- return;- this._disconnected = true;+ private _onDisconnect(error?: Error): Promise<void> {+ if (!this._onDisconnectPromise)+ this._onDisconnectPromise = this._doDisconnect(error);+ return this._onDisconnectPromise;+ }++ private async _doDisconnect(error?: Error) {debugLogger.log('server', `[${this._id}] disconnected. error: ${error}`);await this._root.stopPendingOperations(new Error('Disconnected')).catch(() => {});this._root._dispose();@@ -137,12 +140,13 @@ export class PlaywrightConnection {}async close(reason?: { code: number, reason: string }) {- if (this._disconnected)- return;- debugLogger.log('server', `[${this._id}] force closing connection: ${reason?.reason || ''} (${reason?.code || 0})`);- try {- this._transport.close(reason);- } catch (e) {+ if (!this._onDisconnectPromise) {+ debugLogger.log('server', `[${this._id}] force closing connection: ${reason?.reason || ''} (${reason?.code || 0})`);+ try {+ this._transport.close(reason);+ } catch (e) {+ }}+ await this._onDisconnect();}}