Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(ui-mode): improve toolbar alignment and remove some odd sizings (#37135)

Adam Gastineau4bc9fb38db49
diff --git a/packages/trace-viewer/src/ui/timeline.css b/packages/trace-viewer/src/ui/timeline.css
index b22b48a4c5..fd8dc01ae9 100644
--- a/packages/trace-viewer/src/ui/timeline.css
+++ b/packages/trace-viewer/src/ui/timeline.css
@@ -14,12 +14,17 @@
limitations under the License.
*/
+.timeline-view-container {
+ flex: none;
+ border-bottom: 1px solid var(--vscode-panel-border);
+}
+
.timeline-view {
flex: none;
position: relative;
display: flex;
flex-direction: column;
- padding: 20px 0 5px;
+ padding: 20px 0 4px;
cursor: text;
user-select: none;
margin-left: 10px;
diff --git a/packages/trace-viewer/src/ui/timeline.tsx b/packages/trace-viewer/src/ui/timeline.tsx
index e4010f972c..4e8b194b1a 100644
--- a/packages/trace-viewer/src/ui/timeline.tsx
+++ b/packages/trace-viewer/src/ui/timeline.tsx
@@ -233,7 +233,7 @@ export const Timeline: React.FunctionComponent<{
setSelectedTime(undefined);
}, [setSelectedTime]);
- return <div style={{ flex: 'none', borderBottom: '1px solid var(--vscode-panel-border)' }}>
+ return <div className='timeline-view-container'>
{!!dragWindow && <GlassPane
cursor={dragWindow?.type === 'resize' ? 'ew-resize' : 'grab'}
onPaneMouseUp={onGlassPaneMouseUp}
diff --git a/packages/trace-viewer/src/ui/uiModeView.css b/packages/trace-viewer/src/ui/uiModeView.css
index de89b911c3..c717337622 100644
--- a/packages/trace-viewer/src/ui/uiModeView.css
+++ b/packages/trace-viewer/src/ui/uiModeView.css
@@ -39,6 +39,10 @@
color: var(--vscode-debugIcon-stopForeground);
}
+.ui-mode .section-toolbar {
+ border-top: 1px solid var(--vscode-panel-border);
+}
+
.ui-mode .section-title {
display: flex;
flex: auto;
diff --git a/packages/trace-viewer/src/ui/uiModeView.tsx b/packages/trace-viewer/src/ui/uiModeView.tsx
index 1c3b5ad400..1d561b1c55 100644
--- a/packages/trace-viewer/src/ui/uiModeView.tsx
+++ b/packages/trace-viewer/src/ui/uiModeView.tsx
@@ -454,7 +454,7 @@ export const UIModeView: React.FC<{}> = ({
setProjectFilters={setProjectFilters}
testModel={testModel}
runTests={() => runTests('bounce-if-busy', visibleTestIds)} />
- <Toolbar noMinHeight={true}>
+ <Toolbar className='section-toolbar' noMinHeight={true}>
{!isRunningTest && !progress && <div className='section-title'>Tests</div>}
{!isRunningTest && progress && <div data-testid='status-line' className='status-line'>
<div>{progress.passed}/{progress.total} passed ({(progress.passed / progress.total) * 100 | 0}%)</div>
diff --git a/packages/web/src/components/toolbar.css b/packages/web/src/components/toolbar.css
index 08e3614e34..5a532a77d5 100644
--- a/packages/web/src/components/toolbar.css
+++ b/packages/web/src/components/toolbar.css
@@ -18,7 +18,7 @@
position: relative;
display: flex;
color: var(--vscode-sideBarTitle-foreground);
- min-height: 35px;
+ min-height: 30px;
align-items: center;
flex: none;
padding-right: 4px;