Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(chromium): better error message for evaluate result being collected (#41868)

Dmitry Gozman4cd8608744bf
diff --git a/packages/playwright-core/src/server/chromium/crExecutionContext.ts b/packages/playwright-core/src/server/chromium/crExecutionContext.ts
index 4d31aa7e25..dbdd0e9e58 100644
--- a/packages/playwright-core/src/server/chromium/crExecutionContext.ts
+++ b/packages/playwright-core/src/server/chromium/crExecutionContext.ts
@@ -104,6 +104,8 @@ function rewriteError(error: Error): Protocol.Runtime.evaluateReturnValue {
throw new Error('Cannot serialize result: object reference chain is too long.');
if (error.message.includes('Object couldn\'t be returned by value'))
return { result: { type: 'undefined' } };
+ if (error.message.includes('Promise was collected'))
+ throw new Error('Resulting promise was garbage collected.');
if (error instanceof TypeError && error.message.startsWith('Converting circular structure to JSON'))
rewriteErrorMessage(error, error.message + ' Are you passing a nested JSHandle?');
diff --git a/tests/page/page-evaluate.spec.ts b/tests/page/page-evaluate.spec.ts
index 19166207a4..5b85b8dd66 100644
--- a/tests/page/page-evaluate.spec.ts
+++ b/tests/page/page-evaluate.spec.ts
@@ -889,3 +889,13 @@ it('should ignore dangerous object keys', async ({ page }) => {
const result = await page.evaluate(arg => arg, input);
expect(result).toEqual({ safeKey: 'safeValue' });
});
+
+it('promise collected', async ({ page, browserName }) => {
+ it.skip(browserName !== 'chromium', 'this is a chromium-only behavior');
+
+ const resultPromise = page.evaluate(() => new Promise<void>(() => {})).catch(e => e);
+ for (let i = 0; i < 20; i++)
+ await page.requestGC();
+ const error = await resultPromise;
+ expect(error.message).toContain('Resulting promise was garbage collected');
+});