Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(bidi): add support for fetching response bodies (#37244)

Holger Benl4dd1949df509
diff --git a/packages/playwright-core/src/server/bidi/bidiBrowser.ts b/packages/playwright-core/src/server/bidi/bidiBrowser.ts
index 050952904f..d92e05f898 100644
--- a/packages/playwright-core/src/server/bidi/bidiBrowser.ts
+++ b/packages/playwright-core/src/server/bidi/bidiBrowser.ts
@@ -69,6 +69,11 @@ export class BidiBrowser extends Browser {
],
});
+ await browser._browserSession.send('network.addDataCollector', {
+ dataTypes: [bidi.Network.DataType.Response],
+ maxEncodedDataSize: 20_000_000, // same default as in CDP: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/inspector/inspector_network_agent.cc;l=134;drc=4128411589187a396829a827f59a655bed876aa7
+ });
+
if (options.persistent) {
const context = new BidiBrowserContext(browser, undefined, options.persistent);
browser._defaultContext = context;
diff --git a/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts b/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts
index e5139937d9..b6807e731d 100644
--- a/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts
+++ b/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts
@@ -89,7 +89,9 @@ export class BidiNetworkManager {
if (!request)
return;
const getResponseBody = async () => {
- throw new Error(`Response body is not available for requests in Bidi`);
+ const { bytes } = await this._session.send('network.getData', { request: params.request.request, dataType: bidi.Network.DataType.Response });
+ const encoding = bytes.type === 'base64' ? 'base64' : 'utf8';
+ return Buffer.from(bytes.value, encoding);
};
const timings = params.request.timings;
const startTime = timings.requestTime;
diff --git a/packages/playwright-core/src/server/bidi/third_party/bidiCommands.d.ts b/packages/playwright-core/src/server/bidi/third_party/bidiCommands.d.ts
index 3d04b8d039..65435f08b8 100644
--- a/packages/playwright-core/src/server/bidi/third_party/bidiCommands.d.ts
+++ b/packages/playwright-core/src/server/bidi/third_party/bidiCommands.d.ts
@@ -170,6 +170,19 @@ export interface Commands {
returnType: Bidi.Storage.SetCookieParameters;
};
+ 'network.addDataCollector': {
+ params: Bidi.Network.AddDataCollectorParameters;
+ returnType: Bidi.Network.AddDataCollectorResult;
+ };
+ 'network.removeDataCollector': {
+ params: Bidi.Network.RemoveDataCollectorParameters;
+ returnType: Bidi.Network.RemoveDataCollectorResult;
+ };
+ 'network.getData': {
+ params: Bidi.Network.GetDataParameters;
+ returnType: Bidi.Network.GetDataResult;
+ };
+
'network.addIntercept': {
params: Bidi.Network.AddInterceptParameters;
returnType: Bidi.Network.AddInterceptResult;