Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(fetch): append string and URLSearchParams params to the URL query (#43226)
Pavel Feldman4ed974430aec
diff --git a/packages/playwright-core/src/server/fetch.ts b/packages/playwright-core/src/server/fetch.tsindex cdd5c504d2..60e2b0bfab 100644--- a/packages/playwright-core/src/server/fetch.ts+++ b/packages/playwright-core/src/server/fetch.ts@@ -213,7 +213,10 @@ export abstract class APIRequestContext extends SdkObject {const requestUrl = new URL(constructURLBasedOnBaseURL(defaults.baseURL, params.url));if (params.encodedParams) {- requestUrl.search = params.encodedParams;+ // Append to the query that the URL already has, like the object form does.+ const encodedParams = params.encodedParams.replace(/^\?/, '');+ if (encodedParams)+ requestUrl.search = requestUrl.search ? requestUrl.search + '&' + encodedParams : encodedParams;} else if (params.params) {for (const { name, value } of params.params)requestUrl.searchParams.append(name, value);diff --git a/tests/library/browsercontext-fetch.spec.ts b/tests/library/browsercontext-fetch.spec.tsindex adc2a9d87b..4b1ef5d3e2 100644--- a/tests/library/browsercontext-fetch.spec.ts+++ b/tests/library/browsercontext-fetch.spec.ts@@ -266,6 +266,18 @@ for (const method of ['fetch', 'delete', 'get', 'head', 'patch', 'post', 'put']expect(responseParams.get('парам2')).toBe('знач2');});+ it(`${method} should append string and URLSearchParams params to the URL query`, {+ annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/43210' },+ }, async ({ context, server }) => {+ for (const params of ['q=cat', '?q=cat', new URLSearchParams({ q: 'cat' })]) {+ const [request] = await Promise.all([+ server.waitForRequest('/empty.html?page=2&q=cat'),+ context.request[method](server.EMPTY_PAGE + '?page=2', { params }),+ ]);+ expect(request.url).toBe('/empty.html?page=2&q=cat');+ }+ });+it(`${method} should support failOnStatusCode`, async ({ context, server }) => {const error = await context.request[method](server.PREFIX + '/does-not-exist.html', {failOnStatusCode: true