Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(mcp): check tracing state before stopping in browser_stop_tracing (#41040)
Sebastien Tardif50c8c8d10e21
diff --git a/packages/playwright-core/src/tools/backend/tracing.ts b/packages/playwright-core/src/tools/backend/tracing.tsindex 345f449478..c5bc91ce3e 100644--- a/packages/playwright-core/src/tools/backend/tracing.ts+++ b/packages/playwright-core/src/tools/backend/tracing.ts@@ -61,11 +61,11 @@ const tracingStop = defineTool({handle: async (context, params, response) => {const browserContext = await context.ensureBrowserContext();- await browserContext.tracing.stop();// eslint-disable-next-line no-restricted-syntaxconst traceLegend = (browserContext.tracing as any)[traceLegendSymbol];if (!traceLegend)throw new Error('Tracing is not started');+ await browserContext.tracing.stop();// eslint-disable-next-line no-restricted-syntaxdelete (browserContext.tracing as any)[traceLegendSymbol];diff --git a/tests/mcp/tracing.spec.ts b/tests/mcp/tracing.spec.tsindex a386bc1af5..9f9e0edbde 100644--- a/tests/mcp/tracing.spec.ts+++ b/tests/mcp/tracing.spec.ts@@ -83,3 +83,16 @@ test('check that trace is saved with browser_start_tracing (no output dir)', asyexpect.stringMatching(/trace-\d+\.trace/),]);});++test('browser_stop_tracing without start returns error', async ({ startClient }) => {+ const { client } = await startClient({+ args: ['--caps=tracing'],+ });++ expect(await client.callTool({+ name: 'browser_stop_tracing',+ })).toHaveResponse({+ isError: true,+ error: expect.stringContaining('Tracing is not started'),+ });+});