Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(mcp): pass action timeout to browser_wait_for waitFor calls (#41270)

Sebastien Tardif51d86ccb228f
diff --git a/packages/playwright-core/src/tools/backend/wait.ts b/packages/playwright-core/src/tools/backend/wait.ts
index cdf9e90d13..11aa2a8d5e 100644
--- a/packages/playwright-core/src/tools/backend/wait.ts
+++ b/packages/playwright-core/src/tools/backend/wait.ts
@@ -47,12 +47,12 @@ const wait = defineTool({
if (goneLocator) {
response.addCode(`await page.getByText(${JSON.stringify(params.textGone)}).first().waitFor({ state: 'hidden' });`);
- await goneLocator.waitFor({ state: 'hidden' });
+ await goneLocator.waitFor({ state: 'hidden', ...tab.actionTimeoutOptions });
}
if (locator) {
response.addCode(`await page.getByText(${JSON.stringify(params.text)}).first().waitFor({ state: 'visible' });`);
- await locator.waitFor({ state: 'visible' });
+ await locator.waitFor({ state: 'visible', ...tab.actionTimeoutOptions });
}
response.addTextResult(`Waited for ${params.text || params.textGone || params.time}`);
diff --git a/tests/mcp/timeouts.spec.ts b/tests/mcp/timeouts.spec.ts
index 6038db5b42..4ea3c18a18 100644
--- a/tests/mcp/timeouts.spec.ts
+++ b/tests/mcp/timeouts.spec.ts
@@ -76,6 +76,56 @@ test('action timeout (custom)', async ({ startClient, server }) => {
});
});
+test('wait_for text timeout', async ({ startClient, server }) => {
+ const { client } = await startClient({ args: [`--timeout-action=1234`] });
+ server.setContent('/', `
+ <!DOCTYPE html>
+ <html>
+ <div>Hello World</div>
+ </html>
+ `, 'text/html');
+
+ await client.callTool({
+ name: 'browser_navigate',
+ arguments: {
+ url: server.PREFIX,
+ },
+ });
+
+ expect(await client.callTool({
+ name: 'browser_wait_for',
+ arguments: { text: 'This text will never appear' },
+ })).toHaveResponse({
+ error: expect.stringContaining(`Timeout 1234ms exceeded.`),
+ isError: true,
+ });
+});
+
+test('wait_for textGone timeout', async ({ startClient, server }) => {
+ const { client } = await startClient({ args: [`--timeout-action=1234`] });
+ server.setContent('/', `
+ <!DOCTYPE html>
+ <html>
+ <div>Permanent text</div>
+ </html>
+ `, 'text/html');
+
+ await client.callTool({
+ name: 'browser_navigate',
+ arguments: {
+ url: server.PREFIX,
+ },
+ });
+
+ expect(await client.callTool({
+ name: 'browser_wait_for',
+ arguments: { textGone: 'Permanent text' },
+ })).toHaveResponse({
+ error: expect.stringContaining(`Timeout 1234ms exceeded.`),
+ isError: true,
+ });
+});
+
test('navigation timeout', async ({ startClient, server }) => {
const { client } = await startClient({ args: [`--timeout-navigation=1234`] });
server.setRoute('/slow', async () => {