Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore: restore shared mode to stay non-breaking (#39606)
Pavel Feldman52e5df7bc172
diff --git a/packages/playwright-core/src/mcp/config.d.ts b/packages/playwright-core/src/mcp/config.d.tsindex 99ad58fbf9..35c5ca61fb 100644--- a/packages/playwright-core/src/mcp/config.d.ts+++ b/packages/playwright-core/src/mcp/config.d.ts@@ -137,6 +137,11 @@ export type Config = {*/saveSession?: boolean;+ /**+ * Reuse the same browser context between all connected HTTP clients.+ */+ sharedBrowserContext?: boolean;+/*** Secrets are used to prevent LLM from getting sensitive data while* automating scenarios such as authentication.diff --git a/packages/playwright-core/src/mcp/config.ts b/packages/playwright-core/src/mcp/config.tsindex 1088e834a6..577da213a8 100644--- a/packages/playwright-core/src/mcp/config.ts+++ b/packages/playwright-core/src/mcp/config.ts@@ -64,6 +64,7 @@ export type CLIOptions = {proxyServer?: string;saveSession?: boolean;secrets?: Record<string, string>;+ sharedBrowserContext?: boolean;snapshotMode?: 'incremental' | 'full' | 'none';storageState?: string;testIdAttribute?: string;@@ -252,6 +253,7 @@ export function configFromCLIOptions(cliOptions: CLIOptions): Config & { configFcodegen: cliOptions.codegen,saveSession: cliOptions.saveSession,secrets: cliOptions.secrets,+ sharedBrowserContext: cliOptions.sharedBrowserContext,snapshot: cliOptions.snapshotMode ? { mode: cliOptions.snapshotMode } : undefined,outputMode: cliOptions.outputMode,outputDir: cliOptions.outputDir,diff --git a/packages/playwright-core/src/mcp/configIni.ts b/packages/playwright-core/src/mcp/configIni.tsindex 29c4c743e7..966e4ab617 100644--- a/packages/playwright-core/src/mcp/configIni.ts+++ b/packages/playwright-core/src/mcp/configIni.ts@@ -160,6 +160,7 @@ const longhandTypes: Record<string, LonghandType> = {'saveSession': 'boolean','saveTrace': 'boolean','saveVideo': 'size',+ 'sharedBrowserContext': 'boolean','outputDir': 'string','outputMode': 'string','imageResponses': 'string',diff --git a/packages/playwright-core/src/mcp/program.ts b/packages/playwright-core/src/mcp/program.tsindex f82bf80b47..414db8e0a9 100644--- a/packages/playwright-core/src/mcp/program.ts+++ b/packages/playwright-core/src/mcp/program.ts@@ -63,6 +63,7 @@ export function decorateMCPCommand(command: Command, version: string) {.option('--sandbox', 'enable the sandbox for all process types that are normally not sandboxed.').option('--save-session', 'Whether to save the Playwright MCP session into the output directory.').option('--secrets <path>', 'path to a file containing secrets in the dotenv format', dotenvFileLoader)+ .option('--shared-browser-context', 'reuse the same browser context between all connected HTTP clients.').option('--snapshot-mode <mode>', 'when taking snapshots for responses, specifies the mode to use. Can be "incremental", "full", or "none". Default is incremental.').option('--storage-state <path>', 'path to the storage state file for isolated sessions.').option('--test-id-attribute <attribute>', 'specify the attribute to use for test ids, defaults to "data-testid"')@@ -107,7 +108,7 @@ export function decorateMCPCommand(command: Command, version: string) {return;}- const useSharedBrowser = !!config.browser.userDataDir;+ const useSharedBrowser = config.sharedBrowserContext || config.browser.isolated;let sharedBrowser: playwright.Browser | undefined;let clientCount = 0;diff --git a/tests/mcp/http.spec.ts b/tests/mcp/http.spec.tsindex 1e0b9765b9..af82e24776 100644--- a/tests/mcp/http.spec.ts+++ b/tests/mcp/http.spec.ts@@ -199,8 +199,8 @@ test('http transport browser lifecycle (isolated, multiclient)', async ({ server'create http session': 3,'delete http session': 3,'create context': 3,- 'create browser (isolated)': 3,- 'close browser': 3,+ 'create browser (isolated)': 1,+ 'close browser': 1,});});@@ -236,8 +236,33 @@ test('http transport browser lifecycle (persistent)', async ({ serverEndpoint, s});});+test('http transport browser lifecycle (persistent, multiclient)', async ({ serverEndpoint, server }) => {+ const { url } = await serverEndpoint();++ const transport1 = new StreamableHTTPClientTransport(new URL('/mcp', url));+ const client1 = new Client({ name: 'test', version: '1.0.0' });+ await client1.connect(transport1);+ await client1.callTool({+ name: 'browser_navigate',+ arguments: { url: server.HELLO_WORLD },+ });++ const transport2 = new StreamableHTTPClientTransport(new URL('/mcp', url));+ const client2 = new Client({ name: 'test', version: '1.0.0' });+ await client2.connect(transport2);+ const response = await client2.callTool({+ name: 'browser_navigate',+ arguments: { url: server.HELLO_WORLD },+ });+ expect(response.isError).toBe(true);+ expect(response.content?.[0].text).toContain('use --isolated to run multiple instances of the same browser');++ await client1.close();+ await client2.close();+});+test('http transport shared context', async ({ serverEndpoint, server }) => {- const { url, stderr } = await serverEndpoint();+ const { url, stderr } = await serverEndpoint({ args: ['--shared-browser-context'] });// Create first client and navigateconst transport1 = new StreamableHTTPClientTransport(new URL('/mcp', url));diff --git a/tests/mcp/sse.spec.ts b/tests/mcp/sse.spec.tsindex 322d5bef71..f9f4cbb4ab 100644--- a/tests/mcp/sse.spec.ts+++ b/tests/mcp/sse.spec.ts@@ -125,6 +125,10 @@ test('sse transport browser lifecycle (isolated, multiclient)', async ({ serverEname: 'browser_navigate',arguments: { url: server.HELLO_WORLD },});+ await client1.callTool({+ name: 'browser_evaluate',+ arguments: { function: '() => { localStorage.a = 42; }' },+ });const transport2 = new SSEClientTransport(new URL('/sse', url));const client2 = new Client({ name: 'test', version: '1.0.0' });@@ -133,6 +137,12 @@ test('sse transport browser lifecycle (isolated, multiclient)', async ({ serverEname: 'browser_navigate',arguments: { url: server.HELLO_WORLD },});+ expect(await client2.callTool({+ name: 'browser_evaluate',+ arguments: { function: '() => localStorage.a' },+ })).toHaveResponse({+ result: 'undefined',+ });await client1.close();const transport3 = new SSEClientTransport(new URL('/sse', url));@@ -150,11 +160,36 @@ test('sse transport browser lifecycle (isolated, multiclient)', async ({ serverE'create SSE session': 3,'delete SSE session': 3,'create context': 3,- 'create browser (isolated)': 3,- 'close browser': 3,+ 'create browser (isolated)': 1,+ 'close browser': 1,});});+test('sse transport browser lifecycle (persistent, multiclient)', async ({ serverEndpoint, server }) => {+ const { url } = await serverEndpoint();++ const transport1 = new SSEClientTransport(new URL('/sse', url));+ const client1 = new Client({ name: 'test', version: '1.0.0' });+ await client1.connect(transport1);+ await client1.callTool({+ name: 'browser_navigate',+ arguments: { url: server.HELLO_WORLD },+ });++ const transport2 = new SSEClientTransport(new URL('/sse', url));+ const client2 = new Client({ name: 'test', version: '1.0.0' });+ await client2.connect(transport2);+ const response = await client2.callTool({+ name: 'browser_navigate',+ arguments: { url: server.HELLO_WORLD },+ });+ expect(response.isError).toBe(true);+ expect(response.content?.[0].text).toContain('use --isolated to run multiple instances of the same browser');++ await client1.close();+ await client2.close();+});+test('sse transport browser lifecycle (persistent)', async ({ serverEndpoint, server }) => {const { url, stderr } = await serverEndpoint();@@ -165,6 +200,10 @@ test('sse transport browser lifecycle (persistent)', async ({ serverEndpoint, sename: 'browser_navigate',arguments: { url: server.HELLO_WORLD },});+ await client1.callTool({+ name: 'browser_evaluate',+ arguments: { function: '() => { localStorage.a = 42; }' },+ });await client1.close();const transport2 = new SSEClientTransport(new URL('/sse', url));@@ -174,6 +213,12 @@ test('sse transport browser lifecycle (persistent)', async ({ serverEndpoint, sename: 'browser_navigate',arguments: { url: server.HELLO_WORLD },});+ expect(await client2.callTool({+ name: 'browser_evaluate',+ arguments: { function: '() => localStorage.a' },+ })).toHaveResponse({+ result: '"42"',+ });await client2.close();await expect.poll(() => formatLog(stderr())).toEqual({@@ -186,7 +231,7 @@ test('sse transport browser lifecycle (persistent)', async ({ serverEndpoint, se});test('sse transport shared context', async ({ serverEndpoint, server }) => {- const { url, stderr } = await serverEndpoint();+ const { url, stderr } = await serverEndpoint({ args: ['--shared-browser-context'] });// Create first client and navigateconst transport1 = new SSEClientTransport(new URL('/sse', url));