Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix: adding trialing slash detection logic back in urlToWSEndpoint (#36357)

Kevin Tan556fea944468
diff --git a/packages/playwright-core/src/server/chromium/chromium.ts b/packages/playwright-core/src/server/chromium/chromium.ts
index b35fbb83f0..fdeabb6726 100644
--- a/packages/playwright-core/src/server/chromium/chromium.ts
+++ b/packages/playwright-core/src/server/chromium/chromium.ts
@@ -382,6 +382,8 @@ async function urlToWSEndpoint(progress: Progress, endpointURL: string, headers:
return endpointURL;
progress.log(`<ws preparing> retrieving websocket url from ${endpointURL}`);
const url = new URL(endpointURL);
+ if (!url.pathname.endsWith('/'))
+ url.pathname = url.pathname + '/';
url.pathname += 'json/version/';
const httpURL = url.toString();
diff --git a/tests/library/chromium/connect-over-cdp.spec.ts b/tests/library/chromium/connect-over-cdp.spec.ts
index d5ff791567..389f8838ee 100644
--- a/tests/library/chromium/connect-over-cdp.spec.ts
+++ b/tests/library/chromium/connect-over-cdp.spec.ts
@@ -41,6 +41,23 @@ test('should connect to an existing cdp session', async ({ browserType, mode },
}
});
+test('should connect to an existing cdp session with verbose path', async ({ browserType, mode }, testInfo) => {
+ const port = 9339 + testInfo.workerIndex;
+ const browserServer = await browserType.launch({
+ args: ['--remote-debugging-port=' + port]
+ });
+ try {
+ const cdpBrowser = await browserType.connectOverCDP({
+ endpointURL: `http://127.0.0.1:${port}/json/version/abcdefg`,
+ });
+ const contexts = cdpBrowser.contexts();
+ expect(contexts.length).toBe(1);
+ await cdpBrowser.close();
+ } finally {
+ await browserServer.close();
+ }
+});
+
test('should use logger in default context', async ({ browserType }, testInfo) => {
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/28813' });
const port = 9339 + testInfo.workerIndex;