Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(server): validate file paths in createTempFiles (#40754)

Sebastien Tardif5614c6091e93
diff --git a/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts b/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
index 1770310e05..3170e5e7d0 100644
--- a/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
+++ b/packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
@@ -19,6 +19,7 @@ import path from 'path';
import { deserializeURLMatch, urlMatches } from '@isomorphic/urlMatch';
import { createGuid } from '@utils/crypto';
+import { throwingResolveWithinRoot } from '@utils/fileUtils';
import { BrowserContext } from '../browserContext';
import { CDPSessionDispatcher } from './cdpSessionDispatcher';
import { DebuggerDispatcher } from './debuggerDispatcher';
@@ -232,8 +233,9 @@ export class BrowserContextDispatcher extends Dispatcher<BrowserContext, channel
return {
rootDir: params.rootDirName ? new WritableStreamDispatcher(this, tempDirWithRootName) : undefined,
writableStreams: await Promise.all(params.items.map(async item => {
- await progress.race(fs.promises.mkdir(path.dirname(path.join(tempDirWithRootName, item.name)), { recursive: true }));
- const file = fs.createWriteStream(path.join(tempDirWithRootName, item.name));
+ const itemPath = throwingResolveWithinRoot(tempDirWithRootName, item.name);
+ await progress.race(fs.promises.mkdir(path.dirname(itemPath), { recursive: true }));
+ const file = fs.createWriteStream(itemPath);
return new WritableStreamDispatcher(this, file, item.lastModifiedMs);
}))
};
diff --git a/packages/utils/fileUtils.ts b/packages/utils/fileUtils.ts
index 2a748a92d1..4328e5640d 100644
--- a/packages/utils/fileUtils.ts
+++ b/packages/utils/fileUtils.ts
@@ -93,6 +93,13 @@ export function resolveWithinRoot(root: string, fileName: string): string | null
return isPathInside(root, resolvedFile) ? resolvedFile : null;
}
+export function throwingResolveWithinRoot(root: string, fileName: string): string {
+ const resolved = resolveWithinRoot(root, fileName);
+ if (!resolved)
+ throw new Error(`Path '${fileName}' escapes root directory`);
+ return resolved;
+}
+
export function toPosixPath(aPath: string): string {
return aPath.split(path.sep).join(path.posix.sep);
}