Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(registry): find channels without proper win32 env (#35376)

Max Schmitt5af22ed72e6e
diff --git a/packages/playwright-core/src/server/registry/index.ts b/packages/playwright-core/src/server/registry/index.ts
index e7687d1840..35d4ed0618 100644
--- a/packages/playwright-core/src/server/registry/index.ts
+++ b/packages/playwright-core/src/server/registry/index.ts
@@ -861,7 +861,12 @@ export class Registry {
return undefined;
}
const prefixes = (process.platform === 'win32' ? [
- process.env.LOCALAPPDATA, process.env.PROGRAMFILES, process.env['PROGRAMFILES(X86)']
+ process.env.LOCALAPPDATA,
+ process.env.PROGRAMFILES,
+ process.env['PROGRAMFILES(X86)'],
+ // In some cases there is no PROGRAMFILES/(86) env var set but HOMEDRIVE is set.
+ process.env.HOMEDRIVE + '\\Program Files',
+ process.env.HOMEDRIVE + '\\Program Files (x86)',
].filter(Boolean) : ['']) as string[];
for (const prefix of prefixes) {
@@ -941,7 +946,12 @@ export class Registry {
return undefined;
}
const prefixes = (process.platform === 'win32' ? [
- process.env.LOCALAPPDATA, process.env.PROGRAMFILES, process.env['PROGRAMFILES(X86)']
+ process.env.LOCALAPPDATA,
+ process.env.PROGRAMFILES,
+ process.env['PROGRAMFILES(X86)'],
+ // In some cases there is no PROGRAMFILES/(86) env var set but HOMEDRIVE is set.
+ process.env.HOMEDRIVE + '\\Program Files',
+ process.env.HOMEDRIVE + '\\Program Files (x86)',
].filter(Boolean) : ['']) as string[];
for (const prefix of prefixes) {