Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
devops: respect rolled browserversion (#38813)
Simon Knott5c45053e2ef9
diff --git a/.github/workflows/roll_browser_into_playwright.yml b/.github/workflows/roll_browser_into_playwright.ymlindex 38dd2b2611..b08ba3213a 100644--- a/.github/workflows/roll_browser_into_playwright.yml+++ b/.github/workflows/roll_browser_into_playwright.yml@@ -8,6 +8,7 @@ env:ELECTRON_SKIP_BINARY_DOWNLOAD: 1BROWSER: ${{ github.event.client_payload.browser }}REVISION: ${{ github.event.client_payload.revision }}+ BROWSER_VERSION: ${{ github.event.client_payload.browserVersion }}permissions:contents: write@@ -29,7 +30,7 @@ jobs:run: npx playwright install-deps- name: Roll to new revisionrun: |- ./utils/roll_browser.js $BROWSER $REVISION+ ./utils/roll_browser.js $BROWSER $REVISION $BROWSER_VERSIONnpm run build- name: Prepare branchid: prepare-branchdiff --git a/utils/roll_browser.js b/utils/roll_browser.jsindex 0a50756bae..30d2dee02e 100755--- a/utils/roll_browser.js+++ b/utils/roll_browser.js@@ -71,7 +71,11 @@ Example:}const revision = args[1];+ let browserVersion = args[2];console.log(`Rolling ${browserName} to ${revision}`);+ if (browserVersion) {+ console.log(`Browser version: ${browserVersion}`);+ }// 2. Update browser revisions in browsers.json.console.log('\nUpdating revision in browsers.json...');@@ -88,11 +92,13 @@ Example:// 4. Update browser version if rolling WebKit / Firefox / Chromium.const browserType = playwright[browserName.split('-')[0]];if (browserType) {- const browser = await browserType.launch({- executablePath: executable.executablePath('javascript'),- });- const browserVersion = await browser.version();- await browser.close();+ if (!browserVersion) {+ const browser = await browserType.launch({+ executablePath: executable.executablePath('javascript'),+ });+ browserVersion = await browser.version();+ await browser.close();+ }console.log('\nUpdating browser version in browsers.json...');for (const descriptor of descriptors)descriptor.browserVersion = browserVersion;