Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(trace-viewer): Reset selected network entry on retry (#38691)

Chris5ce840adef3b
diff --git a/packages/trace-viewer/src/ui/networkTab.tsx b/packages/trace-viewer/src/ui/networkTab.tsx
index 6a6071b3ce..e014401cb0 100644
--- a/packages/trace-viewer/src/ui/networkTab.tsx
+++ b/packages/trace-viewer/src/ui/networkTab.tsx
@@ -75,6 +75,8 @@ export const NetworkTab: React.FunctionComponent<{
const [selectedEntry, setSelectedEntry] = React.useState<RenderedEntry | undefined>(undefined);
const [filterState, setFilterState] = React.useState(defaultFilterState);
+ const visibleSelectedEntry = React.useMemo(() => (selectedEntry && networkModel.resources.includes(selectedEntry.resource)) ? selectedEntry : undefined, [selectedEntry, networkModel.resources]);
+
const { renderedEntries } = React.useMemo(() => {
const renderedEntries = networkModel.resources.map((entry, i) => renderEntry(entry, boundaries, networkModel.contextIdMap, i)).filter(filterEntry(filterState));
if (sorting)
@@ -98,10 +100,10 @@ export const NetworkTab: React.FunctionComponent<{
name='network'
ariaLabel='Network requests'
items={renderedEntries}
- selectedItem={selectedEntry}
+ selectedItem={visibleSelectedEntry}
onSelected={item => setSelectedEntry(item)}
onHighlighted={item => onResourceHovered?.(item?.ordinal)}
- columns={visibleColumns(!!selectedEntry, renderedEntries)}
+ columns={visibleColumns(!!visibleSelectedEntry, renderedEntries)}
columnTitle={columnTitle}
columnWidths={columnWidths}
setColumnWidths={setColumnWidths}
@@ -113,14 +115,14 @@ export const NetworkTab: React.FunctionComponent<{
/>;
return <>
<NetworkFilters filterState={filterState} onFilterStateChange={onFilterStateChange} />
- {!selectedEntry && grid}
- {selectedEntry &&
+ {!visibleSelectedEntry && grid}
+ {visibleSelectedEntry &&
<SplitView
sidebarSize={columnWidths.get('name')!}
sidebarIsFirst={true}
orientation='horizontal'
settingName='networkResourceDetails'
- main={<NetworkResourceDetails resource={selectedEntry.resource} sdkLanguage={sdkLanguage} startTimeOffset={selectedEntry.start} onClose={() => setSelectedEntry(undefined)} />}
+ main={<NetworkResourceDetails resource={visibleSelectedEntry.resource} sdkLanguage={sdkLanguage} startTimeOffset={visibleSelectedEntry.start} onClose={() => setSelectedEntry(undefined)} />}
sidebar={grid}
/>}
</>;
diff --git a/tests/playwright-test/ui-mode-test-network-tab.spec.ts b/tests/playwright-test/ui-mode-test-network-tab.spec.ts
index d868775a89..3e04112f95 100644
--- a/tests/playwright-test/ui-mode-test-network-tab.spec.ts
+++ b/tests/playwright-test/ui-mode-test-network-tab.spec.ts
@@ -348,3 +348,28 @@ test('should copy network request', async ({ runUITest, server }) => {
expect(playwrightRequest).toContain(`'content-type': 'application/json'`);
}).toPass();
});
+
+
+test('should not preserve selection across test runs', async ({ runUITest, server }) => {
+ const { page } = await runUITest({
+ 'network-tab.test.ts': `
+ import { test, expect } from '@playwright/test';
+ test('network tab test', async ({ page }) => {
+ await page.goto('${server.PREFIX}/network-tab/network.html');
+ await page.evaluate(() => (window as any).donePromise);
+ });
+ `,
+ });
+
+ await page.getByRole('treeitem', { name: 'network tab test' }).dblclick();
+ await page.getByRole('tab', { name: 'Network' }).click();
+ const networkItem = page.getByRole('listitem').filter({ hasText: 'network.html' });
+ await networkItem.click();
+ const headersPanel = page.getByRole('tabpanel', { name: 'Headers' });
+ await expect(headersPanel).toBeVisible();
+
+ await page.getByRole('treeitem', { name: 'network tab test' }).dblclick();
+ await networkItem.waitFor({ state: 'hidden' });
+ await networkItem.waitFor();
+ await expect(headersPanel).toBeHidden();
+});